Fix issue toggling row selection for a grouped row #4760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mollykreis is attempting to deploy a commit to the Tanstack Team on Vercel. A member of the Team first needs to authorize it. |
|
Unsure if this change is needed as discussed here: #4759 (comment) |
2jordan3
reviewed
May 28, 2024
| @@ -353,7 +353,8 @@ export const RowSelection: TableFeature = { | |||
| table.setRowSelection(old => { | |||
| value = typeof value !== 'undefined' ? value : !isSelected | |||
|
|
|||
| if (isSelected === value) { | |||
| const willUpdateSubRows = row.subRows?.length && row.getCanSelectSubRows() | |||
There was a problem hiding this comment.
row.subRows?.length can be undefined, how about using !! to explicitly convert it to a boolean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4759
Toggling a grouped row can have up to two effects:
getCanSelectSubRowsistruetoggleSelected()returned early if the selected state of the row wasn't going to change without any consideration of whether the selected state of subrows also needed to be updated. With this change,toggleSelected()now considers both if the rows selection state will change and if subrow selection state might change before returning early.I've added some selection tests to
table-core-- both a few basic tests and some tests that cover the issue I am fixing.