-
-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(start): ensure generic h3 functions remain generic, including new overloads #3285
Open
EskiMojo14
wants to merge
2
commits into
TanStack:main
Choose a base branch
from
EskiMojo14:tweak-h3-wrappers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+159
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your CI Pipeline Execution ↗ for commit 39af8f3.
☁️ Nx Cloud last updated this comment at |
EskiMojo14
changed the title
ensure generic h3 functions remain generic, including new overloads
fix!: ensure generic h3 functions remain generic, including new overloads
Jan 30, 2025
EskiMojo14
changed the title
fix!: ensure generic h3 functions remain generic, including new overloads
fix(start)!: ensure generic h3 functions remain generic, including new overloads
Jan 30, 2025
More templates
@tanstack/arktype-adapter
@tanstack/create-start
@tanstack/directive-functions-plugin
@tanstack/create-router
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-cross-context
@tanstack/react-router
@tanstack/react-router-with-query
@tanstack/router-cli
@tanstack/router-devtools
@tanstack/router-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/start
@tanstack/start-api-routes
@tanstack/start-client
@tanstack/start-config
@tanstack/start-plugin
@tanstack/start-router-manifest
@tanstack/start-server
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-handler
@tanstack/start-server-functions-server
@tanstack/start-server-functions-ssr
@tanstack/virtual-file-routes
@tanstack/valibot-adapter
@tanstack/zod-adapter
commit: |
we should use those functions in the e2e test to ensure this still builds |
SeanCassiere
changed the title
fix(start)!: ensure generic h3 functions remain generic, including new overloads
fix(start): ensure generic h3 functions remain generic, including new overloads
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, type parameters weren't being passed through to wrapper functions, meaning things like
useSession<Data>(config)
didn't work properly.This PR ensures the original signature is kept intact, along with providing specifically typed overloads for wrappers that need it.
breaking changes:
any
, and didn't check whether event was truthy.