-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core) onSubmit meta #1131
Open
harry-whorlow
wants to merge
26
commits into
TanStack:main
Choose a base branch
from
harry-whorlow:on-submit-meta
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(core) onSubmit meta #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your CI Pipeline Execution ↗ for commit 27cffc8.
☁️ Nx Cloud last updated this comment at |
harry-whorlow
commented
Jan 28, 2025
harry-whorlow
commented
Jan 28, 2025
85da305
to
ebe6936
Compare
harry-whorlow
commented
Jan 29, 2025
harry-whorlow
commented
Jan 29, 2025
66d467e
to
9bb39fc
Compare
194411d
to
50404a6
Compare
I'm going to give it a go as the generic not extending object, I'm a little unsure why I started with it like this. But, I think restricting the user to what type they can define is a miss-step. |
036b47f
to
0fb2ced
Compare
1c981db
to
d43120a
Compare
harry-whorlow
commented
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From issue #989, this PR introduces onSubmitMeta to the formApi.
Example API shamelessly ripped from #989 and @crutchcorn