Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!![TASK] Relax dependencies to local tables #3764

Conversation

dkd-friedrich
Copy link
Member

@dkd-friedrich dkd-friedrich commented Aug 22, 2023

What this pr does

To allow indexing of external data the dependencies to local tables are relaxed, 4 steps are prepared to achieve this:

  • !!![BUGFIX] Queue check considers indexing configuration
  • !!![TASK] Introduce queue and queue item interfaces
  • [TASK] Consider queue initialization status
  • !!![TASK] Introduce specific EXT:solr exceptions

Most of these changes are breaking, as internal interfaces and exceptions are changed, that might be used outside of EXT:solr.

How to test

This changes just prepares EXT:solr for indexing of external data, the current behaviour is not changed!

Resolves: #3763

@dkd-friedrich dkd-friedrich force-pushed the task/main/3763-relax_dependency_to_local_tables branch 2 times, most recently from f867036 to 8cdd908 Compare August 22, 2023 15:24
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this pull request Aug 22, 2023
As there may be several indexing configurations per type the
queue check has to consider the indexing configuration. The
missing check is added by this commit.

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this pull request Aug 22, 2023
As an initial steps to allow custom index queue types interfaces
for queue and queue items are introduced. Additionally custom
queue classes can be configured via:
plugin.tx_solr.index.queue.<configurationName>.indexQueue

This is a breaking change for all instances that implemented own queues
and queue items!

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this pull request Aug 22, 2023
Queue initialization status returned by the QueueInitializationService
isn't considered in the backend module and a success message is always
shown. This commit adds a check for the returned status and displays an
error message similiar to the message that is shown if an exceptions
occured.

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this pull request Aug 22, 2023
Existing exceptions are now based on the recently introduced
generic EXT:solr exception.

Additionally based on the new generic EXT:solr exception a further
exception is introduced, allowing more targeted handling of exceptions:
InvalidIndexQueueInitizalizationPostProcessorException

This is a breaking change as the base excepion changed and the new
exception is no longer based on \UnexpectedValueException.

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
@dkd-kaehm dkd-kaehm changed the title [TASK] Relax dependencies to local tables !!![TASK] Relax dependencies to local tables Sep 15, 2023
As there may be several indexing configurations per type the
queue check has to consider the indexing configuration. The
missing check is added by this commit.

Resolves: TYPO3-Solr#3763
As an initial steps to allow custom index queue types interfaces
for queue and queue items are introduced. Additionally custom
queue classes can be configured via:
plugin.tx_solr.index.queue.<configurationName>.indexQueue

This is a breaking change for all instances that implemented own queues
and queue items!

Resolves: TYPO3-Solr#3763
Queue initialization status returned by the QueueInitializationService
isn't considered in the backend module and a success message is always
shown. This commit adds a check for the returned status and displays an
error message similiar to the message that is shown if an exceptions
occured.

Resolves: TYPO3-Solr#3763
Existing exceptions are now based on the recently introduced
generic EXT:solr exception.

Additionally based on the new generic EXT:solr exception a further
exception is introduced, allowing more targeted handling of exceptions:
InvalidIndexQueueInitizalizationPostProcessorException

This is a breaking change as the base excepion changed and the new
exception is no longer based on \UnexpectedValueException.

Resolves: TYPO3-Solr#3763
@dkd-kaehm dkd-kaehm force-pushed the task/main/3763-relax_dependency_to_local_tables branch from 8cdd908 to cf5d5e5 Compare September 15, 2023 07:39
@dkd-kaehm dkd-kaehm merged commit 1ed1c4a into TYPO3-Solr:main Sep 15, 2023
8 checks passed
@dkd-kaehm dkd-kaehm deleted the task/main/3763-relax_dependency_to_local_tables branch September 15, 2023 10:55
dkd-kaehm pushed a commit that referenced this pull request Sep 15, 2023
As there may be several indexing configurations per type the
queue check has to consider the indexing configuration. The
missing check is added by this commit.

Ports: #3764
Resolves: #3763
dkd-kaehm pushed a commit that referenced this pull request Sep 15, 2023
As an initial steps to allow custom index queue types interfaces
for queue and queue items are introduced. Additionally custom
queue classes can be configured via:
plugin.tx_solr.index.queue.<configurationName>.indexQueue

This is a breaking change for all instances that implemented own queues
and queue items!

Ports: #3764
Resolves: #3763
dkd-kaehm pushed a commit that referenced this pull request Sep 15, 2023
Queue initialization status returned by the QueueInitializationService
isn't considered in the backend module and a success message is always
shown. This commit adds a check for the returned status and displays an
error message similiar to the message that is shown if an exceptions
occured.

Ports: #3764
Resolves: #3763
dkd-kaehm pushed a commit that referenced this pull request Sep 15, 2023
Existing exceptions are now based on the recently introduced
generic EXT:solr exception.

Additionally based on the new generic EXT:solr exception a further
exception is introduced, allowing more targeted handling of exceptions:
InvalidIndexQueueInitizalizationPostProcessorException

This is a breaking change as the base excepion changed and the new
exception is no longer based on \UnexpectedValueException.

Ports: #3764
Resolves: #3763
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Sep 15, 2023
@dkd-kaehm dkd-kaehm mentioned this pull request Oct 13, 2023
1 task
dkd-kaehm pushed a commit that referenced this pull request Nov 8, 2023
As there may be several indexing configurations per type the
queue check has to consider the indexing configuration. The
missing check is added by this commit.

Ports: #3764
Resolves: #3763
dkd-kaehm pushed a commit that referenced this pull request Nov 8, 2023
As an initial steps to allow custom index queue types interfaces
for queue and queue items are introduced. Additionally custom
queue classes can be configured via:
plugin.tx_solr.index.queue.<configurationName>.indexQueue

This is a breaking change for all instances that implemented own queues
and queue items!

Ports: #3764
Resolves: #3763
dkd-kaehm pushed a commit that referenced this pull request Nov 8, 2023
Queue initialization status returned by the QueueInitializationService
isn't considered in the backend module and a success message is always
shown. This commit adds a check for the returned status and displays an
error message similiar to the message that is shown if an exceptions
occured.

Ports: #3764
Resolves: #3763
dkd-kaehm pushed a commit that referenced this pull request Nov 8, 2023
Existing exceptions are now based on the recently introduced
generic EXT:solr exception.

Additionally based on the new generic EXT:solr exception a further
exception is introduced, allowing more targeted handling of exceptions:
InvalidIndexQueueInitizalizationPostProcessorException

This is a breaking change as the base excepion changed and the new
exception is no longer based on \UnexpectedValueException.

Ports: #3764
Resolves: #3763
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this pull request Mar 11, 2024
As there may be several indexing configurations per type the
queue check has to consider the indexing configuration. The
missing check is added by this commit.

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this pull request Mar 11, 2024
As an initial steps to allow custom index queue types interfaces
for queue and queue items are introduced. Additionally custom
queue classes can be configured via:
plugin.tx_solr.index.queue.<configurationName>.indexQueue

This is a breaking change for all instances that implemented own queues
and queue items!

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this pull request Mar 11, 2024
Queue initialization status returned by the QueueInitializationService
isn't considered in the backend module and a success message is always
shown. This commit adds a check for the returned status and displays an
error message similiar to the message that is shown if an exceptions
occured.

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this pull request Mar 11, 2024
Existing exceptions are now based on the recently introduced
generic EXT:solr exception.

Additionally based on the new generic EXT:solr exception a further
exception is introduced, allowing more targeted handling of exceptions:
InvalidIndexQueueInitizalizationPostProcessorException

This is a breaking change as the base excepion changed and the new
exception is no longer based on \UnexpectedValueException.

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this pull request Mar 13, 2024
As an initial steps to allow custom index queue types interfaces
for queue and queue items are introduced. Additionally custom
queue classes can be configured via:
plugin.tx_solr.index.queue.<configurationName>.indexQueue

This is a breaking change for all instances that implement own
queues and queue items!

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this pull request Mar 13, 2024
Queue initialization status returned by the QueueInitializationService
isn't considered in the backend module and a success message is always
shown. This commit adds a check for the returned status and displays an
error message similiar to the message that is shown if an exceptions
occured.

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this pull request Mar 13, 2024
Existing exceptions are now based on the recently introduced
generic EXT:solr exception.

Additionally based on the new generic EXT:solr exception a further
exception is introduced, allowing more targeted handling of exceptions:
InvalidIndexQueueInitizalizationPostProcessorException

This is a breaking change as the base excepion changed and the new
exception is no longer based on \UnexpectedValueException.

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this pull request Oct 30, 2024
As there may be several indexing configurations per type the
queue check has to consider the indexing configuration. The
missing check is added by this commit.

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this pull request Oct 30, 2024
As an initial steps to allow custom index queue types interfaces
for queue and queue items are introduced. Additionally custom
queue classes can be configured via:
plugin.tx_solr.index.queue.<configurationName>.indexQueue

This is a breaking change for all instances that implement own
queues and queue items!

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this pull request Oct 30, 2024
Queue initialization status returned by the QueueInitializationService
isn't considered in the backend module and a success message is always
shown. This commit adds a check for the returned status and displays an
error message similiar to the message that is shown if an exceptions
occured.

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this pull request Oct 30, 2024
Existing exceptions are now based on the recently introduced
generic EXT:solr exception.

Additionally based on the new generic EXT:solr exception a further
exception is introduced, allowing more targeted handling of exceptions:
InvalidIndexQueueInitizalizationPostProcessorException

This is a breaking change as the base excepion changed and the new
exception is no longer based on \UnexpectedValueException.

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Relax dependencies to local tables
2 participants