Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump virtualenv from 20.25.0 to 20.26.6 #137

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 13, 2025

Bumps virtualenv from 20.25.0 to 20.26.6.

Release notes

Sourced from virtualenv's releases.

20.26.6

What's Changed

New Contributors

Full Changelog: pypa/virtualenv@20.26.5...20.26.6

20.26.5

What's Changed

Full Changelog: pypa/virtualenv@20.26.4...20.26.5

20.26.4

What's Changed

New Contributors

Full Changelog: pypa/virtualenv@20.26.3...20.26.4

20.26.3

What's Changed

Full Changelog: pypa/virtualenv@20.26.2...20.26.3

20.26.2

... (truncated)

Changelog

Sourced from virtualenv's changelog.

v20.26.6 (2024-09-27)

Bugfixes - 20.26.6

- Properly quote string placeholders in activation script templates to mitigate
  potential command injection - by :user:`y5c4l3`. (:issue:`2768`)

v20.26.5 (2024-09-17)

Bugfixes - 20.26.5

  • Upgrade embedded wheels: setuptools to 75.1.0 from 74.1.2 - by :user:gaborbernat. (:issue:2765)

v20.26.4 (2024-09-07)

Bugfixes - 20.26.4

- no longer create `()` output in console during activation of a virtualenv by .bat file. (:issue:`2728`)
- Upgrade embedded wheels:
  • wheel to 0.44.0 from 0.43.0
  • pip to 24.2 from 24.1
  • setuptools to 74.1.2 from 70.1.0 (:issue:2760)

v20.26.3 (2024-06-21)

Bugfixes - 20.26.3

  • Upgrade embedded wheels:

    • setuptools to 70.1.0 from 69.5.1
    • pip to 24.1 from 24.0 (:issue:2741)

v20.26.2 (2024-05-13)

Bugfixes - 20.26.2

- ``virtualenv.pyz`` no longer fails when zipapp path contains a symlink - by :user:`HandSonic` and :user:`petamas`. (:issue:`1949`)
- Fix bad return code from activate.sh if hashing is disabled - by :user:'fenkes-ibm'. (:issue:`2717`)

v20.26.1 (2024-04-29)

Bugfixes - 20.26.1

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 13, 2025
@mreid-tt
Copy link
Contributor

mreid-tt commented Jan 14, 2025

hey @publicarray, with this automatic update we are getting this build error:

FileNotFoundError: [Errno 2] No such file or directory: 'convert'

Now I recall before you mentioned in #108 (comment) that this was as a result of a missing ImageMagick installation.

I attempted to install ImageMagick in a083afd but this did not resolve the issue so I've rolled it back. Any thoughts on how this can be resolved so the tests can pass?

EDIT: Manually pulling in this PR to my test environment (similar to the steps in #102 (comment)), results in a successful test. This issue seems limited to GitHub.

@publicarray
Copy link
Member

publicarray commented Jan 14, 2025

Thanks @mreid-tt for looking into this. It is likely that GitHub has updated their runner/distribution and may not have convert, not sure of it ever had it. To fix it it may be a matter of making sure that the $PATH has convert. Maybe running which -a convert in the GitHub run task can narrow down what is going on?

@mreid-tt mreid-tt force-pushed the dependabot/pip/virtualenv-20.26.6 branch from d1ada08 to 59d0b43 Compare January 15, 2025 13:27
@mreid-tt
Copy link
Contributor

mreid-tt commented Jan 15, 2025

@publicarray, @hgy59, based on the discussion in actions/runner-images#11384, it seems GitHub has updated the runner image from ubuntu-22.04 to ubuntu-24.04. Unlike the previous image, the newer one no longer includes ImageMagick by default.

I attempted to add ImageMagick to the Docker image definition, but it didn’t work as expected. However, adding it directly to the workflow resolved the issue.

I’m unsure if this is the best approach and would appreciate any feedback or suggestions you might have.

EDIT: I've moved this change to a separate PR #138 for review.

@mreid-tt
Copy link
Contributor

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 15, 2025

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@mreid-tt
Copy link
Contributor

@dependabot recreate

Bumps [virtualenv](https://github.com/pypa/virtualenv) from 20.25.0 to 20.26.6.
- [Release notes](https://github.com/pypa/virtualenv/releases)
- [Changelog](https://github.com/pypa/virtualenv/blob/main/docs/changelog.rst)
- [Commits](pypa/virtualenv@20.25.0...20.26.6)

---
updated-dependencies:
- dependency-name: virtualenv
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/virtualenv-20.26.6 branch from 3227b94 to 451b6aa Compare January 15, 2025 15:38
@mreid-tt
Copy link
Contributor

@dependabot squash and merge

@dependabot dependabot bot merged commit e11840a into main Jan 15, 2025
2 checks passed
@dependabot dependabot bot deleted the dependabot/pip/virtualenv-20.26.6 branch January 15, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants