Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(networking): add xev socket backend option #465

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Conversation

kprotty
Copy link
Contributor

@kprotty kprotty commented Dec 19, 2024

Add an implementation of socket_utils.SocketThread using libxev. Disabled for now, but will be evaluated for use in the future.

@kprotty kprotty changed the title perf(networking): improve socket io perf(networking): add xev socket backend option Jan 27, 2025
@kprotty kprotty marked this pull request as ready for review January 27, 2025 18:53
Copy link
Contributor

@Sobeston Sobeston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits, overall seems good

Copy link
Contributor

@Sobeston Sobeston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good

@kprotty kprotty added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 1262202 Feb 4, 2025
12 of 13 checks passed
@kprotty kprotty deleted the king/optimize-io branch February 4, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Gossip + Shred Collector: revisit socket thread design Network: Socket Read/Write Optimizations
2 participants