Remove conflict to symfony/polyfill-mbstring #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added a commit
to SyliusLabs/PolyfillSymfonyFrameworkBundle
that referenced
this pull request
Oct 31, 2022
This PR was merged into the 1.1-dev branch.
Discussion
----------
I don't know why the conflict existed, and there is no sound track about it on git/github but the conflict forbids using the standard composer mechanism to replace the polyfill and use an extension instead.
```json
{
"replace": {
"symfony/polyfill-mbstring": "*"
}
}
```
See the SyliusLabs/PolyfillSymfonySecurity#6
Commits
-------
16f973f Remove conflict to symfony/polyfill-mbstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why the conflict existed, and there is no good track about it on git/github but the conflict forbids using the standard composer mechanism to replace the polyfill and use extension instead.
{ "replace": { "symfony/polyfill-mbstring": "*" } }