[UpgradeToModular] Remove duplicated classes and correct some wrong namespaces #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
reviewed
Jan 31, 2025
Comment on lines
+29
to
+30
| use \Sylius\MultiStorePlugin\BusinessUnits\Domain\Model\BusinessUnitAwareTrait; | ||
| use \Sylius\MultiStorePlugin\CustomerPools\Domain\Model\CustomerPoolAwareTrait; |
There was a problem hiding this comment.
Why are you moving it? Trait calls should be before the constructor
There was a problem hiding this comment.
Tests are failing otherwise
|
Replaced by #33 |
NoResponseMate
added a commit
that referenced
this pull request
Feb 3, 2025
Tests will be fixed later by #31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the duplicated keys to integration services assuming the migration from sylius/plus will be to application with all the plugins 🤔