Skip to content

Commit

Permalink
Bring back the Price History rector rules
Browse files Browse the repository at this point in the history
  • Loading branch information
@jakubtobiasz
jakubtobiasz committed Mar 1, 2024
1 parent 639cf99 commit 4c0f6fd
Show file tree
Hide file tree
Showing 4 changed files with 98 additions and 81 deletions.
93 changes: 54 additions & 39 deletions config/sets/sylius/price-history/up-sylius-1.13-with-price-history-plugin-to-sylius-1.13.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,45 +3,60 @@
declare(strict_types=1);

use Rector\Config\RectorConfig;
use Rector\Removing\Rector\Class_\RemoveTraitUseRector;
use Rector\Renaming\Rector\Name\RenameClassRector;

return static function (RectorConfig $rectorConfig): void {
// $rectorConfig->ruleWithConfiguration(RenameNamespaceRector::class, [
// 'Sylius\PriceHistoryPlugin\Application\Calculator\ProductVariantLowestPriceCalculator' => 'Sylius\Component\Core\Calculator\ProductVariantPriceCalculator',
// 'Sylius\PriceHistoryPlugin\Application\Checker' => 'Sylius\Component\Core\Checker',
// 'Sylius\PriceHistoryPlugin\Application\Command' => 'Sylius\Bundle\CoreBundle\PriceHistory\Command',
// 'Sylius\PriceHistoryPlugin\Application\CommandDispatcher' => 'Sylius\Bundle\CoreBundle\PriceHistory\CommandDispatcher',
// 'Sylius\PriceHistoryPlugin\Application\CommandHandler' => 'Sylius\Bundle\CoreBundle\PriceHistory\CommandHandler',
// 'Sylius\PriceHistoryPlugin\Application\Logger' => 'Sylius\Bundle\CoreBundle\PriceHistory\Logger',
// 'Sylius\PriceHistoryPlugin\Application\Processor' => 'Sylius\Bundle\CoreBundle\PriceHistory\Processor',
// 'Sylius\PriceHistoryPlugin\Application\Remover\ChannelPricingLogEntriesRemoverInterface' => 'Sylius\Bundle\CoreBundle\PriceHistory\Remover\ChannelPricingLogEntriesRemoverInterface',
// 'Sylius\PriceHistoryPlugin\Application\Templating\Helper' => 'Sylius\Bundle\CoreBundle\Templating\Helper',
// 'Sylius\PriceHistoryPlugin\Application\Validator\ResourceInputDataPropertiesValidatorInterface' => 'Sylius\Bundle\ApiBundle\Validator\ResourceInputDataPropertiesValidatorInterface',
// 'Sylius\PriceHistoryPlugin\Domain\Factory' => 'Sylius\Component\Core\Factory',
// 'Sylius\PriceHistoryPlugin\Domain\Model\ChannelInterface' => 'Sylius\Component\Core\Model\ChannelInterface',
// 'Sylius\PriceHistoryPlugin\Domain\Model\ChannelPriceHistoryConfig' => 'Sylius\Component\Core\Model\ChannelPriceHistoryConfig',
// 'Sylius\PriceHistoryPlugin\Domain\Model\ChannelPriceHistoryConfigInterface' => 'Sylius\Component\Core\Model\ChannelPriceHistoryConfigInterface',
// 'Sylius\PriceHistoryPlugin\Domain\Model\ChannelPricingInterface' => 'Sylius\Component\Core\Model\ChannelPricingInterface',
// 'Sylius\PriceHistoryPlugin\Domain\Model\ChannelPricingLogEntry' => 'Sylius\Component\Core\Model\ChannelPricingLogEntry',
// 'Sylius\PriceHistoryPlugin\Domain\Model\ChannelPricingLogEntryInterface' => 'Sylius\Component\Core\Model\ChannelPricingLogEntryInterface',
// 'Sylius\PriceHistoryPlugin\Domain\Model\LowestPriceBeforeDiscountAwareInterface' => 'Sylius\Component\Core\Model\ChannelPricingInterface',
// 'Sylius\PriceHistoryPlugin\Domain\Repository\ChannelPricingLogEntryRepositoryInterface' => 'Sylius\Component\Core\Repository\ChannelPricingLogEntryRepositoryInterface',
// 'Sylius\PriceHistoryPlugin\Infrastructure\Cli\Command' => 'Sylius\Bundle\CoreBundle\PriceHistory\Cli\Command',
// 'Sylius\PriceHistoryPlugin\Infrastructure\Doctrine\ORM\ChannelPricingLogEntryRepository' => 'Sylius\Bundle\CoreBundle\Doctrine\ORM\ChannelPricingLogEntryRepository',
// 'Sylius\PriceHistoryPlugin\Infrastructure\Doctrine\ORM\ChannelPricingLogEntryRepositoryInterface' => 'Sylius\Component\Core\Repository\ChannelPricingLogEntryRepositoryInterface',
// 'Sylius\PriceHistoryPlugin\Infrastructure\EntityObserver' => 'Sylius\Bundle\CoreBundle\PriceHistory\EntityObserver',
// 'Sylius\PriceHistoryPlugin\Infrastructure\Event' => 'Sylius\Bundle\CoreBundle\PriceHistory\Event',
// 'Sylius\PriceHistoryPlugin\Infrastructure\Event\OldChannelPricingLogEntriesEvents' => 'Sylius\Bundle\CoreBundle\PriceHistory\Event\OldChannelPricingLogEntriesEvents',
// 'Sylius\PriceHistoryPlugin\Infrastructure\EventListener' => 'Sylius\Bundle\CoreBundle\PriceHistory\EventListener',
// 'Sylius\PriceHistoryPlugin\Infrastructure\EventSubscriber' => 'Sylius\Bundle\CoreBundle\PriceHistory\EventSubscriber',
// 'Sylius\PriceHistoryPlugin\Infrastructure\Form' => 'Sylius\Bundle\CoreBundle\Form',
// 'Sylius\PriceHistoryPlugin\Infrastructure\Provider' => 'Sylius\Component\Core\Provider',
// 'Sylius\PriceHistoryPlugin\Infrastructure\Remover\ChannelPricingLogEntriesRemover' => 'Sylius\Bundle\CoreBundle\PriceHistory\Remover\ChannelPricingLogEntriesRemover',
// 'Sylius\PriceHistoryPlugin\Infrastructure\Serializer' => 'Sylius\Bundle\ApiBundle\Serializer',
// 'Sylius\PriceHistoryPlugin\Infrastructure\Twig' => 'Sylius\Bundle\CoreBundle\Twig',
// 'Sylius\PriceHistoryPlugin\Infrastructure\Validator' => 'Sylius\Bundle\ApiBundle\Validator',
// ]);
// $rectorConfig->ruleWithConfiguration(RemoveTraitUseRector::class, [
// 'Sylius\PriceHistoryPlugin\Domain\Model\ChannelPriceHistoryConfigAwareTrait',
// 'Sylius\PriceHistoryPlugin\Domain\Model\LowestPriceBeforeDiscountAwareTrait',
// ]);
$rectorConfig->ruleWithConfiguration(RenameClassRector::class, [
'Sylius\PriceHistoryPlugin\Application\Calculator\ProductVariantLowestPriceCalculator' => 'Sylius\Component\Core\Calculator\ProductVariantPriceCalculator',
'Sylius\PriceHistoryPlugin\Application\Calculator\ProductVariantLowestPriceCalculatorInterface' => 'Sylius\Component\Core\Calculator\ProductVariantPriceCalculatorInterface',
'Sylius\PriceHistoryPlugin\Application\Checker\ProductVariantLowestPriceDisplayChecker' => 'Sylius\Component\Core\Checker\ProductVariantLowestPriceDisplayChecker',
'Sylius\PriceHistoryPlugin\Application\Checker\ProductVariantLowestPriceDisplayCheckerInterface' => 'Sylius\Component\Core\Checker\ProductVariantLowestPriceDisplayCheckerInterface',
'Sylius\PriceHistoryPlugin\Application\Command\ApplyLowestPriceOnChannelPricings' => 'Sylius\Bundle\CoreBundle\PriceHistory\Command\ApplyLowestPriceOnChannelPricings',
'Sylius\PriceHistoryPlugin\Application\CommandDispatcher\ApplyLowestPriceOnChannelPricingsCommandDispatcherInterface' => 'Sylius\Bundle\CoreBundle\PriceHistory\CommandDispatcher\ApplyLowestPriceOnChannelPricingsCommandDispatcherInterface',
'Sylius\PriceHistoryPlugin\Application\CommandDispatcher\BatchedApplyLowestPriceOnChannelPricingsCommandDispatcher' => 'Sylius\Bundle\CoreBundle\PriceHistory\CommandDispatcher\BatchedApplyLowestPriceOnChannelPricingsCommandDispatcher',
'Sylius\PriceHistoryPlugin\Application\CommandHandler\ApplyLowestPriceOnChannelPricingsHandler' => 'Sylius\Bundle\CoreBundle\PriceHistory\CommandHandler\ApplyLowestPriceOnChannelPricingsHandler',
'Sylius\PriceHistoryPlugin\Application\Logger\PriceChangeLogger' => 'Sylius\Bundle\CoreBundle\PriceHistory\Logger\PriceChangeLogger',
'Sylius\PriceHistoryPlugin\Application\Logger\PriceChangeLoggerInterface' => 'Sylius\Bundle\CoreBundle\PriceHistory\Logger\PriceChangeLoggerInterface',
'Sylius\PriceHistoryPlugin\Application\Processor\ProductLowestPriceBeforeDiscountProcessor' => 'Sylius\Bundle\CoreBundle\PriceHistory\Processor\ProductLowestPriceBeforeDiscountProcessor',
'Sylius\PriceHistoryPlugin\Application\Processor\ProductLowestPriceBeforeDiscountProcessorInterface' => 'Sylius\Bundle\CoreBundle\PriceHistory\Processor\ProductLowestPriceBeforeDiscountProcessorInterface',
'Sylius\PriceHistoryPlugin\Application\Remover\ChannelPricingLogEntriesRemoverInterface' => 'Sylius\Bundle\CoreBundle\PriceHistory\Remover\ChannelPricingLogEntriesRemoverInterface',
'Sylius\PriceHistoryPlugin\Application\Templating\Helper\PriceHelper' => 'Sylius\Bundle\CoreBundle\Templating\Helper\PriceHelper',
'Sylius\PriceHistoryPlugin\Application\Validator\ResourceInputDataPropertiesValidatorInterface' => 'Sylius\Bundle\ApiBundle\Validator\ResourceInputDataPropertiesValidatorInterface',
'Sylius\PriceHistoryPlugin\Domain\Factory\ChannelFactory' => 'Sylius\Component\Core\Factory\ChannelFactory',
'Sylius\PriceHistoryPlugin\Domain\Factory\ChannelPricingLogEntryFactory' => 'Sylius\Component\Core\Factory\ChannelPricingLogEntryFactory',
'Sylius\PriceHistoryPlugin\Domain\Factory\ChannelPricingLogEntryFactoryInterface' => 'Sylius\Component\Core\Factory\ChannelPricingLogEntryFactoryInterface',
'Sylius\PriceHistoryPlugin\Domain\Model\ChannelInterface' => 'Sylius\Component\Core\Model\ChannelInterface',
'Sylius\PriceHistoryPlugin\Domain\Model\ChannelPriceHistoryConfig' => 'Sylius\Component\Core\Model\ChannelPriceHistoryConfig',
'Sylius\PriceHistoryPlugin\Domain\Model\ChannelPriceHistoryConfigInterface' => 'Sylius\Component\Core\Model\ChannelPriceHistoryConfigInterface',
'Sylius\PriceHistoryPlugin\Domain\Model\ChannelPricingInterface' => 'Sylius\Component\Core\Model\ChannelPricingInterface',
'Sylius\PriceHistoryPlugin\Domain\Model\ChannelPricingLogEntry' => 'Sylius\Component\Core\Model\ChannelPricingLogEntry',
'Sylius\PriceHistoryPlugin\Domain\Model\ChannelPricingLogEntryInterface' => 'Sylius\Component\Core\Model\ChannelPricingLogEntryInterface',
'Sylius\PriceHistoryPlugin\Domain\Model\LowestPriceBeforeDiscountAwareInterface' => 'Sylius\Component\Core\Model\ChannelPricingInterface',
'Sylius\PriceHistoryPlugin\Domain\Repository\ChannelPricingLogEntryRepositoryInterface' => 'Sylius\Component\Core\Repository\ChannelPricingLogEntryRepositoryInterface',
'Sylius\PriceHistoryPlugin\Infrastructure\Cli\Command\ClearPriceHistoryCommand' => 'Sylius\Bundle\CoreBundle\PriceHistory\Cli\Command\ClearPriceHistoryCommand',
'Sylius\PriceHistoryPlugin\Infrastructure\Doctrine\ORM\ChannelPricingLogEntryRepository' => 'Sylius\Bundle\CoreBundle\Doctrine\ORM\ChannelPricingLogEntryRepository',
'Sylius\PriceHistoryPlugin\Infrastructure\Doctrine\ORM\ChannelPricingLogEntryRepositoryInterface' => 'Sylius\Component\Core\Repository\ChannelPricingLogEntryRepositoryInterface',
'Sylius\PriceHistoryPlugin\Infrastructure\EntityObserver\CreateLogEntryOnPriceChangeObserver' => 'Sylius\Bundle\CoreBundle\PriceHistory\EntityObserver\CreateLogEntryOnPriceChangeObserver',
'Sylius\PriceHistoryPlugin\Infrastructure\EntityObserver\EntityObserverInterface' => 'Sylius\Bundle\CoreBundle\PriceHistory\EntityObserver\EntityObserverInterface',
'Sylius\PriceHistoryPlugin\Infrastructure\EntityObserver\ProcessLowestPricesOnChannelChangeObserver' => 'Sylius\Bundle\CoreBundle\PriceHistory\EntityObserver\ProcessLowestPricesOnChannelChangeObserver',
'Sylius\PriceHistoryPlugin\Infrastructure\EntityObserver\ProcessLowestPricesOnChannelPriceHistoryConfigChangeObserver' => 'Sylius\Bundle\CoreBundle\PriceHistory\EntityObserver\ProcessLowestPricesOnChannelPriceHistoryConfigChangeObserver',
'Sylius\PriceHistoryPlugin\Infrastructure\Event\OldChannelPricingLogEntriesEvents' => 'Sylius\Bundle\CoreBundle\PriceHistory\Event\OldChannelPricingLogEntriesEvents',
'Sylius\PriceHistoryPlugin\Infrastructure\EventListener\OnFlushEntityObserverListener' => 'Sylius\Bundle\CoreBundle\PriceHistory\EventListener\OnFlushEntityObserverListener',
'Sylius\PriceHistoryPlugin\Infrastructure\EventSubscriber\ChannelPricingLogEntryEventSubscriber' => 'Sylius\Bundle\CoreBundle\PriceHistory\EventSubscriber\ChannelPricingLogEntryEventSubscriber',
'Sylius\PriceHistoryPlugin\Infrastructure\Form\Extension\ChannelTypeExtension' => 'Sylius\Bundle\CoreBundle\Form\Extension\ChannelTypeExtension',
'Sylius\PriceHistoryPlugin\Infrastructure\Form\Type\ChannelPriceHistoryConfigType' => 'Sylius\Bundle\CoreBundle\Form\Type\ChannelPriceHistoryConfigType',
'Sylius\PriceHistoryPlugin\Infrastructure\Provider\ProductVariantsPricesProvider' => 'Sylius\Component\Core\Provider\ProductVariantsPricesProvider',
'Sylius\PriceHistoryPlugin\Infrastructure\Remover\ChannelPricingLogEntriesRemover' => 'Sylius\Bundle\CoreBundle\PriceHistory\Remover\ChannelPricingLogEntriesRemover',
'Sylius\PriceHistoryPlugin\Infrastructure\Serializer\ChannelDenormalizer' => 'Sylius\Bundle\ApiBundle\Serializer\ChannelDenormalizer',
'Sylius\PriceHistoryPlugin\Infrastructure\Serializer\ChannelPriceHistoryConfigDenormalizer' => 'Sylius\Bundle\ApiBundle\Serializer\ChannelPriceHistoryConfigDenormalizer',
'Sylius\PriceHistoryPlugin\Infrastructure\Serializer\ProductVariantNormalizer' => 'Sylius\Bundle\ApiBundle\Serializer\ProductVariantNormalizer',
'Sylius\PriceHistoryPlugin\Infrastructure\Twig\PriceExtension' => 'Sylius\Bundle\CoreBundle\Twig\PriceExtension',
'Sylius\PriceHistoryPlugin\Infrastructure\Twig\SyliusVersionExtension' => 'Sylius\Bundle\CoreBundle\Twig\SyliusVersionExtension',
'Sylius\PriceHistoryPlugin\Infrastructure\Validator\ResourceApiInputDataPropertiesValidator' => 'Sylius\Bundle\ApiBundle\Validator\ResourceApiInputDataPropertiesValidator',
]);
$rectorConfig->ruleWithConfiguration(RemoveTraitUseRector::class, [
'Sylius\PriceHistoryPlugin\Domain\Model\ChannelPriceHistoryConfigAwareTrait',
'Sylius\PriceHistoryPlugin\Domain\Model\LowestPriceBeforeDiscountAwareTrait',
]);
};
4 changes: 0 additions & 4 deletions tests/Set/PriceHistory/Fixture/class_renaming.php.inc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

namespace Sylius\SyliusRector\Tests\Rector\Class_\AddInterfaceToClassExtendingType\Fixture;

use Sylius\PriceHistoryPlugin\Domain\Model\ChannelPricingInterface;

class SomeClass
{
function someFunction(\Sylius\PriceHistoryPlugin\Domain\Model\ChannelPricingInterface $someOldClass): \Sylius\PriceHistoryPlugin\Domain\Model\ChannelPricingInterface
Expand All @@ -18,8 +16,6 @@ class SomeClass

namespace Sylius\SyliusRector\Tests\Rector\Class_\AddInterfaceToClassExtendingType\Fixture;

use Sylius\Component\Core\Model\ChannelPricingInterface;

class SomeClass
{
function someFunction(\Sylius\Component\Core\Model\ChannelPricingInterface $someOldClass): \Sylius\Component\Core\Model\ChannelPricingInterface
Expand Down
41 changes: 22 additions & 19 deletions tests/Set/PriceHistory/UpgradeSylius112WithPriceHistoryPluginToSylius113Test.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,25 @@

namespace Sylius\SyliusRector\Tests\Set\PriceHistory;

//final class UpgradeSylius112WithPriceHistoryPluginToSylius113Test extends AbstractRectorTestCase
//{
// /** @dataProvider provideData() */
// public function test(string $file): void
// {
// $this->doTestFile($file);
// }
//
// /** @return Iterator<string> */
// public function provideData(): Iterator
// {
// return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
// }
//
// public function provideConfigFilePath(): string
// {
// return __DIR__ . '/config/configured_rule.php';
// }
//}
use Iterator;
use Rector\Testing\PHPUnit\AbstractRectorTestCase;

final class UpgradeSylius112WithPriceHistoryPluginToSylius113Test extends AbstractRectorTestCase
{
/** @dataProvider provideData() */
public function test(string $file): void
{
$this->doTestFile($file);
}

/** @return Iterator<string> */
public function provideData(): Iterator
{
return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
}

public function provideConfigFilePath(): string
{
return __DIR__ . '/config/configured_rule.php';
}
}
41 changes: 22 additions & 19 deletions tests/Set/PriceHistoryPlugin/PriceHistoryPluginTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,25 @@

namespace Sylius\SyliusRector\Tests\Set\PriceHistoryPlugin;

//final class PriceHistoryPluginTest extends AbstractRectorTestCase
//{
// /** @dataProvider provideData() */
// public function test(string $file): void
// {
// $this->doTestFile($file);
// }
//
// /** @return Iterator<string> */
// public function provideData(): Iterator
// {
// return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
// }
//
// public function provideConfigFilePath(): string
// {
// return __DIR__ . '/config/configured_rule.php';
// }
//}
use Iterator;
use Rector\Testing\PHPUnit\AbstractRectorTestCase;

final class PriceHistoryPluginTest extends AbstractRectorTestCase
{
/** @dataProvider provideData() */
public function test(string $file): void
{
$this->doTestFile($file);
}

/** @return Iterator<string> */
public function provideData(): Iterator
{
return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
}

public function provideConfigFilePath(): string
{
return __DIR__ . '/config/configured_rule.php';
}
}

0 comments on commit 4c0f6fd

Please sign in to comment.