[Demo] Init dashboard statistics #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diimpp
reviewed
Feb 15, 2025
| @@ -61,6 +63,14 @@ class Speaker implements ResourceInterface | |||
| #[ORM\OneToOne(cascade: ['persist', 'remove'])] | |||
| private ?SpeakerAvatar $avatar = null; | |||
|
|
|||
| #[ORM\ManyToMany(targetEntity: Talk::class, mappedBy: 'speakers')] | |||
| private Collection $talks; | |||
There was a problem hiding this comment.
Shouldn't be there getters/setters for this collection?
| @@ -26,4 +26,23 @@ public function __construct(ManagerRegistry $registry) | |||
| { | |||
| parent::__construct($registry, Conference::class); | |||
| } | |||
|
|
|||
| public function findTotalConferences(\DatePeriod $datePeriod): int | |||
There was a problem hiding this comment.
A nitpick, would be cool to follow sylius/core-bundle notation as in example.
Suggested change
| public function findTotalConferences(\DatePeriod $datePeriod): int | |
| public function getTotalConferences(\DatePeriod $datePeriod): int |
Comment on lines
+32
to
+35
| $queryBuilder = $this->createQueryBuilder('o'); | ||
|
|
||
| $queryBuilder | ||
| ->select('COUNT(o.id)') |
There was a problem hiding this comment.
Suggested change
| $queryBuilder = $this->createQueryBuilder('o'); | |
| $queryBuilder | |
| ->select('COUNT(o.id)') | |
| return (int) $this->createQueryBuilder('o') | |
| ->select('COUNT(o.id)') |
Comment on lines
+37
to
+43
| $queryBuilder->expr()->gte('o.startsAt', ':start_date'), | ||
| ) | ||
| ->andWhere( | ||
| $queryBuilder->expr()->lt('o.startsAt', ':end_date'), | ||
| ) | ||
| ->setParameter('start_date', $datePeriod->getStartDate()) | ||
| ->setParameter('end_date', $datePeriod->getEndDate()) |
There was a problem hiding this comment.
I think it's more common within sylius to use camelCase for parameters.
Suggested change
| $queryBuilder->expr()->gte('o.startsAt', ':start_date'), | |
| ) | |
| ->andWhere( | |
| $queryBuilder->expr()->lt('o.startsAt', ':end_date'), | |
| ) | |
| ->setParameter('start_date', $datePeriod->getStartDate()) | |
| ->setParameter('end_date', $datePeriod->getEndDate()) | |
| $queryBuilder->expr()->gte('o.startsAt', ':startDate'), | |
| ) | |
| ->andWhere( | |
| $queryBuilder->expr()->lt('o.startsAt', ':endDate'), | |
| ) | |
| ->setParameter('startDate', $datePeriod->getStartDate()) | |
| ->setParameter('endDate', $datePeriod->getEndDate()) |
There was a problem hiding this comment.
Same comments for other repository methods.
| return $queryBuilder->getQuery()->getResult(); | ||
| } | ||
|
|
||
| public function findTotalTalks(\DatePeriod $datePeriod): int |
There was a problem hiding this comment.
--- findTotalTalks
+++ findTotalSpeakers
Suggested change
| public function findTotalTalks(\DatePeriod $datePeriod): int | |
| public function getTotalSpeakers(\DatePeriod $datePeriod): int |
Suggested change
| public function findTotalTalks(\DatePeriod $datePeriod): int | |
| public function getTotalSpeakersWithTalksInPeriod(\DatePeriod $datePeriod): int |
| return $queryBuilder->getQuery()->getResult(); | ||
| } | ||
|
|
||
| public function findTotalTalks(\DatePeriod $datePeriod): int |
There was a problem hiding this comment.
Suggested change
| public function findTotalTalks(\DatePeriod $datePeriod): int | |
| public function getTotalTalks(\DatePeriod $datePeriod): int |
Comment on lines
+33
to
+38
| day: Jour | ||
| lifetime: Durée de vie | ||
| month: Mois | ||
| week: Semaine | ||
| 2weeks: 2 Semaines | ||
| year: Année |
There was a problem hiding this comment.
This is english translation file, please translate 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #237
dashboard_statistics_demo.webm