Chore - Splitting Twig hooks configuration in test application #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diimpp
reviewed
Feb 14, 2025
| @@ -1,64 +1,8 @@ | |||
| imports: | |||
| - { resource: '../sylius/twig_hooks/**/**' } | |||
There was a problem hiding this comment.
Why not
config/packages/app/twig_hooks/**/**config/packages/sylius_twig_hooks/**/**
or other similar path -- main point it should be inside config/packages as per symfony notation.
There was a problem hiding this comment.
We need to make a poll on it and make an ADR or something. Currently sylius-standard/plugin-skeleton and other places uses all kind of notations.
| sylius_twig_hooks: | ||
| hooks: | ||
| 'app.base': | ||
| content: | ||
| template: 'base/content.html.twig' | ||
|
|
||
| 'sylius_admin.common.show.content': |
There was a problem hiding this comment.
This hookable is not extracted into separate file -- is this intentional?
| configuration: | ||
| icon: tabler:list-details | ||
|
|
||
| 'sylius_admin.book.index.content.header': |
There was a problem hiding this comment.
This hookable is not extracted into separate file -- is this intentional?
| 'configuration' => [ | ||
| 'title' => 'app.ui.new_conference', | ||
| 'icon' => 'tabler:plus', | ||
| 'subheader' => 'app.ui.managing_your_conferences', |
There was a problem hiding this comment.
On unrelated note, it should be either title / subtitle or header / subheader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.