Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compat 1.11 #85

Merged
merged 2 commits into from
Jan 6, 2025
Merged

compat 1.11 #85

merged 2 commits into from
Jan 6, 2025

Conversation

xgdgsc
Copy link
Contributor

@xgdgsc xgdgsc commented Jan 6, 2025 •
edited
Loading

fix #84

@thautwarm
Copy link
Member

Thanks for your quick fix!

My concern is that REPL >= 1.11 is a bit rigid here. This library is also used by some commercial ecosystem relying on Julia 1.9.

Besides, I wonder if doc should refer to Base.doc?

julia> typeof(Base.doc).name.module
Base.Docs

@thautwarm
Copy link
Member

I prefer removing REPL from dependencies and replace import REPL.doc with import Base: doc

@thautwarm thautwarm merged commit 8e6b6d5 into Suzhou-Tongyuan:main Jan 6, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.11 support
2 participants
@xgdgsc @thautwarm