Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc enhancements for migrated v2 apps #5209

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

sachin-sumologic
Copy link
Contributor

Purpose of this pull request

This pull request...

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Mar 26, 2025
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sachin-sumologic, the build test for this PR is failing because there is no /reuse/apps/app-install-sc-k8s.md file. Correct the problem before submitting for review again. I placed this PR into draft mode since it is still a work in progress.

To find this sort of problem in the future, build locally first to make sure the PR is ready to review.

@jpipkin1 jpipkin1 marked this pull request as draft March 26, 2025 14:41
Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sachin-sumologic , please move your /reuse files into the /reuse/apps folder.

Screenshot 2025-04-02 at 11 29 30 PM

@@ -0,0 +1,20 @@
To install the app, do the following:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pasted at the wrong location. It should be under docs/reuse/apps

@@ -0,0 +1,26 @@
To update the app, do the following:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pasted at the wrong location. It should be under docs/reuse/apps

@@ -0,0 +1,27 @@
To set up collection and install the app, do the following:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pasted at the wrong location. It should be under docs/reuse/apps

Copy link
Collaborator

@amee-sumo amee-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few commits. Please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Contributor approved, listed in .clabot file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants