[BugFix] Fix tablet scheduler exception #52925
Open
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sevev <[email protected]>
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
| continue; | ||
| } | ||
| list.add(tablet); | ||
| count--; | ||
| } | ||
| return list; | ||
| } |
There was a problem hiding this comment.
The most risky bug in this code is:
Potential race condition or inconsistency issues due to missing finalizeTabletCtx call if checkIfTabletExpired returns true or throws an exception.
You can modify the code like this:
private synchronized List<TabletSchedCtx> getNextTabletCtxBatch() {
while (count > 0) {
Tablet tablet = getTablet();
if (tablet == null) {
// no more tablets
break;
}
try {
// ignore tablets that will expire and erase soon
if (checkIfTabletExpired(tablet)) {
finalizeTabletCtx(tablet, TabletSchedCtx.State.EXPIRED, "Tablet expired");
continue;
}
list.add(tablet);
count--;
} catch (Exception e) {
LOG.warn("got unexpected exception, discard this schedule. tablet: {}",
tablet.getTabletId(), e);
finalizeTabletCtx(tablet, TabletSchedCtx.State.UNEXPECTED, e.getMessage());
}
}
return list;
}By ensuring that finalizeTabletCtx is called whenever skipping a tablet, we avoid potential leaks in state management.
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 4 / 8 (50.00%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
If
TabletSchedulerencountered an unhandled exception when scheduling pending tablets, it only removed the task but did not remove the task_ctx. Consequently, subsequent scheduling will ignore these tablets, and clone and other tasks will no longer be triggered, ultimately causing the alter task to stall.e.g
What I'm doing:
Catch the exception and remove the tablet_ctx.
Fixes https://github.com/StarRocks/StarRocksTest/issues/8829
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: