Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Trino dialect, the extract function supports dow and week parameters #52651

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[Feature] Trino dialect, the extract function supports dow and week parameters #52651

wants to merge 10 commits into from
+20 −3

Conversation

renzhimin7
Copy link
Contributor

@renzhimin7 renzhimin7 commented Nov 5, 2024 •
edited
Loading

Why I'm doing:

extract(dow FROM TIMESTAMP '2022-10-20 05:10:00') not support trino dialect.

set sql_dialect='trino';
SELECT extract(dow FROM TIMESTAMP '2022-10-20 05:10:00');
ERROR 1064 (HY000): Getting analyzing error. Detail message: No matching function with signature: dow(datetime).

What I'm doing:

Fixes #52698

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
  • 3.3
  • 3.2
  • 3.1
  • 3.0
  • 2.5

@renzhimin7 renzhimin7 requested a review from a team as a code owner November 5, 2024 16:05
miomiocat
miomiocat previously approved these changes Nov 7, 2024
View reviewed changes
@miomiocat miomiocat enabled auto-merge (squash) November 7, 2024 11:17
auto-merge was automatically disabled November 8, 2024 08:34

Head branch was pushed to by a user without write access

Youngwb
Youngwb previously approved these changes Nov 12, 2024
View reviewed changes
trueeyu
trueeyu previously approved these changes Nov 14, 2024
View reviewed changes
dirtysalt
dirtysalt reviewed Nov 14, 2024
View reviewed changes
...core/src/main/java/com/starrocks/connector/parser/trino/Trino2SRFunctionCallTransformer.java Outdated
@@ -232,6 +232,8 @@ private static void registerDateFunctionTransformer() {
// last_day_of_month(x) -> last_day(x,'month')
registerFunctionTransformer("last_day_of_month", 1, new FunctionCallExpr("last_day",
List.of(new PlaceholderExpr(1, Expr.class), new StringLiteral("month"))));
// year -> year
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have this year->year function?

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 7 / 7 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/parser/trino/Trino2SRFunctionCallTransformer.java 2 2 100.00% []
🔵 com/starrocks/connector/parser/trino/AstBuilder.java 5 5 100.00% []

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirtysalt dirtysalt dirtysalt left review comments

@trueeyu trueeyu trueeyu left review comments

@miomiocat miomiocat Awaiting requested review from miomiocat

@Youngwb Youngwb Awaiting requested review from Youngwb

At least 2 approving reviews are required to merge this pull request.

Assignees

@renzhimin7 renzhimin7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trino dialect the extract function not supports dow and week parameters
5 participants
@renzhimin7 @dirtysalt @Youngwb @trueeyu @miomiocat