Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disallow cloth to be the second argument of ontop/inside/under #258

Merged
merged 1 commit into from
Feb 16, 2024
Merged

disallow cloth to be the second argument of ontop/inside/under #258

merged 1 commit into from
Feb 16, 2024

Conversation

ChengshuLi
Copy link
Member

No description provided.

cgokmen
cgokmen approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@cgokmen cgokmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the detailed fix here, I think there might be some issues here in terms of how to fit certain objects in paper bags etc. but we'll cross that bridge when we reach it.

@ChengshuLi ChengshuLi merged commit 4e2c9ce into develop Feb 16, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgokmen cgokmen cgokmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChengshuLi @cgokmen