fixes and refactors linux build scripts #8269
Open
+215
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubienr
force-pushed
the
ubuntu-build-fixes
branch
2 times, most recently
from
f825563 to
3617f4a
Compare
rubienr
force-pushed
the
ubuntu-build-fixes
branch
from
3617f4a to
6eaab5e
Compare
|
Dear maintainer|s, I would like to prepare the next PR (on top of this) where Is there something i can do to help and make this PR review easier? Kind regards, |
rubienr
force-pushed
the
ubuntu-build-fixes
branch
from
6eaab5e to
acc5212
Compare
CommanderRedYT
approved these changes
Feb 7, 2025
rubienr
force-pushed
the
ubuntu-build-fixes
branch
3 times, most recently
from
5e37ea8 to
c661915
Compare
build_linux.sh: fixes wrong AppImage build folder; refactors script; enhances help text harmonizes names: BuildLinux.sh and BuildLinuxImage.sh fixes file permissions: cmake inherits .in-file permisson; removes chmod 755 in scripts linux.d/debian: removes false positive error message updates documentation
rubienr
force-pushed
the
ubuntu-build-fixes
branch
from
c661915 to
85ff75f
Compare
…rkflows,src/platform/unix}/build_*
rubienr
force-pushed
the
ubuntu-build-fixes
branch
from
85ff75f to
8b7e369
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a new OrcaSlicer user i found myself not being able to build from source on Ubuntu 24.10.
Details
build_linux.shbuild_*.(sh|bat)scriptsBuildLinux.shandBuildLinuxImage.shcmakeinherits*.in-file permissions for target fileschmod 755in scriptslinux.d/debianNotes
Dockerfiledepends on PR changes but fix should not break itTests
./build_linux.sh -u./build_linux.sh -d./build_linux.sh -s./build_linux.sh -ibuild/OrcaSlicer_Linux_V2.3.0-dev.AppImage; started successfullybuild/package/bin/orca-slicer; started successfully