Fix 10-25% overhang slowdown not working as expected #8080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 18, 2025
|
Tests done. Looks good I think! Regression test 1: Speed for 10-25% is set to 0, hence the value should be ignored and the speed should be unchanged between this PR and the current orca release: Left - this PR - Right - Orca 2.2 Significant improvement should be observed when having a partial overhang between 10% and 25% instead of simply clamping down to the 25% speed when the overhang is exactly 25% Left - this PR - Right - Orca 2.2 |
|
Thanks! @igiannakas Old: New: |
|
Perfect, looks like it works as expected thank you |
3 tasks
…-slowdown-not-working-as-expected
|
Is this going to be merged anytime soon? |
|
Wonderful |
igiannakas
deleted the
Fix-10-25%-overhang-slowdown-not-working-as-expected
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 10-25% overhang was being ignored with overhang slowdown being applied immediately when the overhang reached 25%. This meant that any overhangs, say at 15% were not slowed down, but the moment they hit 25% they were clamped to the 10-25% overhang speed.
As reported here: #7685
This PR introduces slowdown starting at 10+% - 25% as indicated by the text box label by setting the minimum overhang boundary where slowdown is not applied to 10% (instead of 25%) and shifting the remaining overhang %'s one slot downwards in the code, making use of the existing unutilised slots.
Tests
Regression test 1: Speed for 10-25% is set to 0, hence the value should be ignored and the speed should be unchanged between this PR and the current orca release:
Left - this PR - Right - Orca 2.2
Significant improvement should be observed when having a partial overhang between 10% and 25% instead of simply clamping down to the 25% speed when the overhang is exactly 25%
Left - this PR - Right - Orca 2.2
Perfect! Slowdown is now performed correctly between the 10-25% range instead of being ignored.
Fixes: #7685