Feat/bo liste territoires 636 #598
Merged
+765
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-scherer
force-pushed
the
feat/bo-liste-territoires-636
branch
from
8539df0
to
ad8b60c
Compare
l-scherer
force-pushed
the
feat/bo-liste-territoires-636
branch
from
744914d
to
0d06125
Compare
benjaminDNUM
reviewed
Nov 7, 2024
packages/frontend-bo/src/pages/territoires/[[territoireId]].vue
Outdated
Show resolved
Hide resolved
packages/frontend-bo/src/pages/territoires/[[territoireId]].vue
Outdated
Show resolved
Hide resolved
packages/frontend-bo/src/pages/territoires/[[territoireId]].vue
Outdated
Show resolved
Hide resolved
packages/frontend-bo/src/pages/territoires/[[territoireId]].vue
Outdated
Show resolved
Hide resolved
l-scherer
force-pushed
the
feat/bo-liste-territoires-636
branch
from
0d06125
to
6a102a3
Compare
l-scherer
force-pushed
the
feat/bo-liste-territoires-636
branch
from
6a102a3
to
1c5e339
Compare
l-scherer
temporarily deployed
to
review-auto
GitHub Actions
Inactive
|
🎉 Deployment for commit 1c5e339 : Ingresses
Docker images
|
iNeoO
reviewed
Nov 12, 2024
iNeoO
reviewed
Nov 12, 2024
packages/frontend-bo/src/pages/territoires/[[territoireId]].vue
Outdated
Show resolved
Hide resolved
iNeoO
reviewed
Nov 12, 2024
iNeoO
reviewed
Nov 12, 2024
iNeoO
reviewed
Nov 12, 2024
iNeoO
reviewed
Nov 12, 2024
iNeoO
reviewed
Nov 12, 2024
l-scherer
force-pushed
the
feat/bo-liste-territoires-636
branch
from
1c5e339
to
cc2572f
Compare
l-scherer
had a problem deploying
to
review-auto
GitHub Actions
Failure
iNeoO
reviewed
Nov 13, 2024
iNeoO
reviewed
Nov 13, 2024
iNeoO
reviewed
Nov 13, 2024
iNeoO
reviewed
Nov 13, 2024
| log.i("readTerritoires - DONE"); | ||
| return { | ||
| total: userTerritoire.rows.count, | ||
| users: userTerritoire.rows, |
There was a problem hiding this comment.
Est ce que ce ne serait pas interessant d'avoir directement de la pagination ?
There was a problem hiding this comment.
On a une volumétrie maitrisée, on intègrera ton nouveau composant DSFR rapidement après.
iNeoO
reviewed
Nov 13, 2024
iNeoO
reviewed
Nov 13, 2024
packages/frontend-bo/src/pages/territoires/[[territoireId]].vue
Outdated
Show resolved
Hide resolved
iNeoO
reviewed
Nov 13, 2024
packages/frontend-bo/src/pages/territoires/[[territoireId]].vue
Outdated
Show resolved
Hide resolved
iNeoO
reviewed
Nov 13, 2024
packages/frontend-bo/src/pages/territoires/[[territoireId]].vue
Outdated
Show resolved
Hide resolved
iNeoO
reviewed
Nov 13, 2024
iNeoO
reviewed
Nov 13, 2024
| }); | ||
| if (territoires) { | ||
| this.territoires = territoires.map((territoire) => ({ | ||
| territoireId: territoire.territoire_id, |
There was a problem hiding this comment.
est ce que ça ne serait pas mieux de faire ce rename en backend ?
There was a problem hiding this comment.
Tu peux préciser le fond de ta pensée ?
|
faudrait faire des tests unitaires sur les nouveaux endpoints |
l-scherer
force-pushed
the
feat/bo-liste-territoires-636
branch
from
cc2572f
to
a8e2124
Compare
l-scherer
had a problem deploying
to
review-auto
GitHub Actions
Failure
feat(BO): ficher territoire wip 2 636 feat(BO): liste territoire et détail 635-636 fix: prise en compte Issues
l-scherer
force-pushed
the
feat/bo-liste-territoires-636
branch
from
a8e2124
to
114fd35
Compare
l-scherer
had a problem deploying
to
review-auto
GitHub Actions
Failure
|
l-scherer
had a problem deploying
to
review-auto
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajout de la liste des territoires avec les infos du territoire.
Ajout de l'écran de détail des infos du territoire, modifiable par le territoire lui même et la région si c'est un département.