FIX: buffer overflow in integer when setting to 1e10 and enhance documentation #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdymercury
changed the title
|
Sorry for the long wait. Looks good, but please stick to the Slicer style commit prefixes. For documentation only changes use |
It caused the value to be randomly cut to int (undefined behavior, platform dependent). Convert underlying data type to long to avoid this truncation. Cast also multiplication to long, since int ^ 2 can easily surpass the limits of int. Also fix UTF8 accented char in docu
|
Thanks Csaba for the review! I reworded as suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cpinter It caused the value to be randomly cut to int (MAX_INT<1e10) (undefined behavior, platform dependent).
Convert underlying data type to long to avoid this truncation. Cast also multiplication to long, since int ^ 2 can easily surpass the limits of int.