Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO JIRA]: Update popover fallback to align with floating-ui #3700

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

olliecurtis
Copy link
Member

This PR updates the fallback return value for the renderTarget property due to a change in @floating-ui/[email protected].

fix(FloatingPortal): allow root to be reactive from null to an element. ⚠️ an always-null value will never render a portal node as this indicates it's waiting for an element; it must be undefined

When the value is set to be () => null it will never render the popover and mean that it can never be displayed.

This PR also removes old .d.ts files as these are autogenerated at the build and aren't needed

@olliecurtis olliecurtis added the patch Patch production bug label Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

Visit https://backpack.github.io/storybook-prs/3700 to see this build running in a browser.

Copy link

github-actions bot commented Jan 6, 2025

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against b0eef32

@olliecurtis olliecurtis merged commit 5d753df into main Jan 6, 2025
10 checks passed
@olliecurtis olliecurtis deleted the no-jira-update-popover-type branch January 6, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants