Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ST-5444 Updating npm version to match LTS/Node stable pairing #3204

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

adammccullagh
Copy link
Contributor

@adammccullagh adammccullagh commented Jan 29, 2024

The current Internal node stable version includes an update to npm 10. Additionally, the .nvmrc file pins the LTS/hydrogen version - which too expects npm 10 as a pairing.

I have previously updated backpack-node-sass and bpk-svgs. These

The change is backwards compatible and thus this should only be a minor bump.

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

Sorry, something went wrong.

@adammccullagh adammccullagh added the minor Non breaking change label Jan 29, 2024
Copy link

Visit https://backpack.github.io/storybook-prs/3204 to see this build running in a browser.

Updating to accept any version above NPM 9

Co-authored-by: Ollie Curtis <[email protected]>
Copy link

Visit https://backpack.github.io/storybook-prs/3204 to see this build running in a browser.

@olliecurtis olliecurtis added patch Patch production bug and removed minor Non breaking change labels Jan 29, 2024
@olliecurtis
Copy link
Member

@adammccullagh I have changed the label and semver to be patch as the only thing that will affect the release is the bpk-svgs version bump in the packages folder. As any change to the root level package.json only impacts those running the project locally and not the production published version

@olliecurtis olliecurtis merged commit 8e19b29 into main Jan 29, 2024
@olliecurtis olliecurtis deleted the NOJIRA_Bump_npm_version branch January 29, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants