This repository was archived by the owner on Dec 2, 2024. It is now read-only.
[LEOP-154]set cpu count by provide an env var from external to create correct workers number #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SophiaChen2021
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have observed that scripts that spin up worker processes use os.cpus.length() to determine the number of available CPU cores.
When this is used within a docker container, the os.cpus.length() returns the number of cpu cores the host has, not the container.
Hence many more workers are spawned (in our tests 43 workers when we have only 8 cores) which impacts performance.
so we should set the CPU number as a static value when run in a docker container to avoid impacting our pipeline performance.
reference: LEOP-154
Doc: The impact to our pipeline by spinning up lots more workers than cpus