[Next.js] XMC Forms support without BYOC #2052
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illiakovalenko
commented
Mar 12, 2025
Comment on lines
+44
to
+49
| api={{ | ||
| edge: { | ||
| contextId: config.sitecoreEdgeContextId, | ||
| edgeUrl: config.sitecoreEdgeUrl, | ||
| }, | ||
| }} |
There was a problem hiding this comment.
Added a new file because of this portion
illiakovalenko
commented
Mar 12, 2025
| @@ -14,6 +14,10 @@ const monorepoPlugin = (nextConfig = {}) => { | |||
| './node_modules/@sitecore-feaas/clientside/dist/browser/react.esm.js' | |||
| ); | |||
|
|
|||
There was a problem hiding this comment.
Workaround for "monorepo" setup, since we need to reference the same package
art-alexeyenko
requested changes
Mar 12, 2025
| if (isEditing) { | ||
| if (error) { | ||
| return ( | ||
| <div className="sc-jss-placeholder-error">There was a problem loading this section</div> |
There was a problem hiding this comment.
Let's add some guidance to this message, i.e.
"There was a problem loading this section. Check debug logs for sitecore-jss:form for more details"
Or perhaps we can log the caught error in console? While debug log will have entries from loadForm exceptions, user won't know what happened if somehow context.api.edge is undefined.
art-alexeyenko
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Core
Formutilities to enable shared logic across different implementations.React Form
Formcomponent.SitecoreContextto support a globalapiconfiguration. This is currently necessary for theFormcomponent to perform requests.Angular Form
stylesandRenderingIdentifierparameters.Formfunctionality from thesitecore-jsspackage.Testing Details
Types of changes