[sitecore-jss-nextjs]: Update Link.tsx to support next/link's prefetch property #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to disable prefetching on links. Without a change like this, it is not possible to disable prefetching See https://nextjs.org/docs/pages/api-reference/components/link#prefetch
|
@art-alexeyenko @illiakovalenko @yavorsk any chance one of you could have a quick look? |
chrissnyder2337
changed the title
|
Thanks for the contribution @chrissnyder2337 ! I added a ticket to review and add unit tests |
illiakovalenko
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
@chrissnyder2337 Thank you for your contribution! Your effort is appreciated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Linkcomponent in thesitecore-jss-nextjspackage does not currently support the prefetch prop from Next.js's<Link/>component. This limitation prevents developers from conditionally utilizing Next.js's prefetching capabilities for internal links. Prefetching can improve page load performance by preloading linked pages in the background; however, this can increase hosting costs.See https://nextjs.org/docs/pages/api-reference/components/link#prefetch
Description / Motivation
Without the prefetch property, Next.js defaults to prefetching being enabled. This change exposes the property to allow it to be enabled or disabled as needed. Some applications may prefer to disable it on some links to reduce overall hosting usage. According to the Vercel documentation on optimizing edge requests, reducing the amount of prefetching can decrease the number of requests made to your site, which can help manage hosting costs.
Testing Details
Types of changes