Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[templates/nextjs-sxa]: Fixed unsafe property access in SXA components #SXA-7749 #2035

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi commented Feb 6, 2025

Description / Motivation

Fixed unsafe property access in SXA components by replacing direct calls with optional chaining (e.g., props.params.styles → props?.params?.styles).

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Ruslan Matkovskyi added 2 commits February 6, 2025 22:46
@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugfix/SXA-7749-fixed-styles-in-components branch from 2a4abbb to c297021 Compare February 11, 2025 11:30
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yavorsk yavorsk merged commit ae6f916 into dev Feb 11, 2025
1 check passed
@yavorsk yavorsk deleted the bugfix/SXA-7749-fixed-styles-in-components branch February 11, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants