Added exceptions for showing irrelevant values #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed Armor class 31 from armors of units since Obsolete. Removed 0 attacks of units (like archers having 0 vs Rams, etc), but made sure that armor classes having units with negative armor are rendered properly. Exceptions are hardcoded - may need to be updated with time. Current exceptions: War Elephants, Cavalry and Siege Weapons since Ballista Elephants have -2 armor in each. Mounted Archers since Elephant Archers have -7 armor. Base melee since Rams have negative armor.
|
Hmm that is a lot of hardcoding based on the current balance… |
|
So what did you think of it? |
|
I think I prefer to keep it as it currently is |
|
@LOSER4ever is it possible to author this without the class ID hardcoding? |
|
You need to check all armor classes across units to see if the unit has negative armor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Armor class 31 from armors of units since Obsolete.
Removed 0 attacks of units (like archers having 0 vs Rams, etc), but made sure that armor classes having units with negative armor are rendered properly.
Exceptions are hardcoded - may need to be updated with time.
Current exceptions: War Elephants, Cavalry and Siege Weapons since Ballista Elephants have -2 armor in each. Mounted Archers since Elephant Archers have -7 armor. Base melee since Rams have negative armor.