Fix positioning bug when point value is zero (microsoft#30296)

Shubhabrata08 · Jan 12, 2024 · ca4ebf9 · ca4ebf9
1 parent 50176a6
commit ca4ebf9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/change/@fluentui-react-a9048d78-da7c-4392-94b8-9863b78a2885.json b/change/@fluentui-react-a9048d78-da7c-4392-94b8-9863b78a2885.json
@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix: positioning properly tests if point is at the zero location, instead of returning false",
+  "packageName": "@fluentui/react",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}
diff --git a/packages/react/src/utilities/positioning/positioning.ts b/packages/react/src/utilities/positioning/positioning.ts
@@ -775,7 +775,6 @@ function _positionBeak(beakWidth: number, elementPosition: IElementPositionInfo)
   } else if (!_isEdgeInBounds(beakPosition, elementBounds, negativeEdge)) {
     beakPosition = _alignEdges(beakPosition, elementBounds, negativeEdge);
   }
-
   return beakPosition;
 }
 
@@ -995,11 +994,11 @@ function _getRectangleFromTarget(target: Element | MouseEvent | Point | Rectangl
   let targetRect: Rectangle;
 
   // eslint-disable-next-line deprecation/deprecation
-  const left = rectOrPointTarget.left || rectOrPointTarget.x;
+  const left = rectOrPointTarget.left ?? rectOrPointTarget.x;
   // eslint-disable-next-line deprecation/deprecation
-  const top = rectOrPointTarget.top || rectOrPointTarget.y;
-  const right = rectOrPointTarget.right || left;
-  const bottom = rectOrPointTarget.bottom || top;
+  const top = rectOrPointTarget.top ?? rectOrPointTarget.y;
+  const right = rectOrPointTarget.right ?? left;
+  const bottom = rectOrPointTarget.bottom ?? top;
 
   // eslint-disable-next-line no-extra-boolean-cast -- may not actually be a MouseEvent
   if (!!mouseTarget.stopPropagation) {