v18.0.8-shopify-1 #206
Open
v18.0.8-shopify-1 #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremy Cole <[email protected]> Sprinkle addPadding everywhere when comparing KeyRange Start/End values Implement support for PartialVindex usage Signed-off-by: Jeremy Cole <[email protected]> (cherry picked from commit 7424fff) (cherry picked from commit 69e6248) (cherry picked from commit 8390560) (cherry picked from commit b0cad30)
shanth96
force-pushed
the
v18.0.8-shopify-1-candidate
branch
13 times, most recently
from
15e1fed to
bf89367
Compare
|
This is now ready to review. Note: percona-xtrabackup-24 is not available in ubuntu-24.04 hence why the 5 test failures. |
brendar
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Looks good, but there were two test job failures that don't appear related to xtrabackup, vreplication_across_db_versions and vreplication_basic. I'm not concerned about the failures themselves, but it would be preferable to have these tests running. They're both failing with a library loading issue.
E0116 22:54:18.034221 37165 mysqld.go:598] execCmd: /tmp/mysql-5.7/bin/mysqld failed: exit status 127
cluster_test.go:482:
Error Trace: /home/runner/work/vitess/vitess/go/test/endtoend/vreplication/cluster_test.go:482
/home/runner/work/vitess/vitess/go/test/endtoend/vreplication/cluster_test.go:540
/home/runner/work/vitess/vitess/go/test/endtoend/vreplication/cluster_test.go:422
/home/runner/work/vitess/vitess/go/test/endtoend/vreplication/vreplication_test.go:321
/home/runner/work/vitess/vitess/go/test/endtoend/vreplication/vreplication_test.go:298
/home/runner/work/vitess/vitess/go/test/endtoend/vreplication/vreplication_test.go:294
Error: Received unexpected error:
/tmp/mysql-5.7/bin/mysqld: exit status 127, output: /tmp/mysql-5.7/bin/mysqld: error while loading shared libraries: libaio.so.1: cannot open shared object file: No such file or directory
I think we were running them under Ubuntu 22.04 on our v18.0.5 patch. Would that work?
fix tests for CI (cherry picked from commit aa73e7f)
…port-vtcombo-vschema Backport: VTCombo: Ensure VSchema exists when creating keyspace (vitessio#16094) (cherry picked from commit 4b24c58)
…bo-conn-leak Backport v18: vtcombo: close query service on drop database (cherry picked from commit ede4ad1)
…n-to-v18 Backport: Gracefully shutdown VTGate instances (cherry picked from commit 8ba1756)
Fix zookeeper connection leak (cherry picked from commit fc128dc)
…thcheck-on-topo-error Fix v18 tablets removed from healthcheck when topo server GetTablet call fails (cherry picked from commit a46ede6)
These templates were rendered using text/template which is fundamentally broken as it would allow for trivial HTML injection. Instead render using safehtml/template so that we have automatic escaping. Signed-off-by: Dirkjan Bussink <[email protected]>
shanth96
force-pushed
the
v18.0.8-shopify-1-candidate
branch
from
bf89367 to
0b1e29b
Compare
Yea that seems reasonable. Will try that |
|
That seems to have worked!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to all the commits reported by the script, I also cherry-picked vitessio@c3dc4a9 since that has a CVE fix for GHSA-7mwh-q3xm-qh6p