This repository has been archived by the owner on Jul 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 95
Add checks for validating translations in {% schema %} #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f56b01
to
ebdb2f6
Compare
jbourassa
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! 👍
keys.map { |path| (key_prefix + path).join(".") }.join(", ") | ||
end | ||
|
||
def visit_object(default, other, path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 good renaming, much better than the previous ones!
END | ||
) | ||
assert_offenses(<<~END, offenses) | ||
unexpected token at '{ in JSON at sections/product.liquid:1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, we might even be able to increment that :1
with the line number from the {% schema %}
tag (one day, not now).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! I created a ticket to do this: #71. That would be awesome!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{% schema %}
contains JSON that can contain locales. Similar to the ones under locales/:This new check
MatchingSchemaTranslations
, applies the same check to"locales"
asMatchingTranslations
does to locales/*.json. I refactored the common code underLocaleDiff
.Also, an undocumented feature of the schema tag is that all keys that end up in the UI can be localized too:
This new check, makes sure all keys have defined all the known locales used in the schema.
Not perfect, but it does match the errors of existing checks on project-64k (
yarn build --checkTargetLocales
):Fix #68