Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Add docs for unathenticated admin to main page #2241

Merged
merged 2 commits into from
Mar 26, 2025
Merged

[Docs] Add docs for unathenticated admin to main page #2241

merged 2 commits into from
Mar 26, 2025

Conversation

lizkenyon
Copy link
Contributor

WHY are these changes introduced?

Fixes GraphQL client is missing from shopifyApp instance

  • People often miss how to make API calls in background jobs
  • Adds a item to the main page explicitly calls out background jobs, and non shopify initiated requests

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used pnpm changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@lizkenyon lizkenyon requested a review from a team as a code owner March 19, 2025 20:17
byrichardpowell
byrichardpowell reviewed Mar 24, 2025
View reviewed changes
Copy link
Contributor

@byrichardpowell byrichardpowell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content, looks good, but please how can I view it as it's rendered to users?

@lizkenyon
Add docs for unathenticated admin to main page
d14919d 
People often miss how to make API calls in background jobs
@lizkenyon lizkenyon force-pushed the add-docs-unauthenticated branch from 72cfa02 to fabb60d Compare March 25, 2025 19:49
@lizkenyon
Build docs, and resolve example issues
eac32a0 
The graphql examples were previously missing
@lizkenyon lizkenyon force-pushed the add-docs-unauthenticated branch from fabb60d to eac32a0 Compare March 25, 2025 19:57
@byrichardpowell byrichardpowell self-requested a review March 26, 2025 16:07
@lizkenyon lizkenyon merged commit 4e1f261 into main Mar 26, 2025
6 checks passed
@lizkenyon lizkenyon deleted the add-docs-unauthenticated branch March 26, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrichardpowell byrichardpowell byrichardpowell approved these changes

Assignees
No one assigned
Labels
Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GraphQL client is missing from shopifyApp instance
2 participants
@lizkenyon @byrichardpowell