Skip to content

[Patch] Don't set retry headers on extension requests #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2025
Merged

[Patch] Don't set retry headers on extension requests #2123

merged 2 commits into from
Feb 20, 2025

Conversation

lizkenyon
Copy link
Contributor

@lizkenyon lizkenyon commented Feb 19, 2025 •
edited
Loading

WHY are these changes introduced?

Fixes #0000

Because of the functionality changes in Make library compatible with Remix v3_singleFetch, we need be able to set whether or not a request should be retried from validateSessionToken

Extension requests shouldn't be set to be retried, as there is no app bridge to intercept the request.

WHAT is this pull request doing?

  • Adds an optional param set if request should be retried.
  • Defaults to true to keep current functionality
  • Sets to to false for extensions

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used pnpm changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@lizkenyon lizkenyon changed the title [Patch] Don [Patch] Don't set retry headers on extension requests Feb 19, 2025
@lizkenyon lizkenyon marked this pull request as ready for review February 19, 2025 20:13
@lizkenyon lizkenyon requested a review from a team as a code owner February 19, 2025 20:13
sle-c
sle-c approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@sle-c sle-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed no change in functionality, simply an optional param

@lizkenyon lizkenyon merged commit c762ca0 into main Feb 20, 2025
6 checks passed
@lizkenyon lizkenyon deleted the liz/dont-retry-invalid-session-extensions branch February 20, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sle-c sle-c sle-c approved these changes

@byrichardpowell byrichardpowell Awaiting requested review from byrichardpowell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lizkenyon @sle-c