Replace assert with rbs_assert for better assertion message
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
changed the title
assert with rbs_assert for better assertion messagesassert with rbs_assert for better assertion message
amomchilov
reviewed
Mar 17, 2025
include/rbs/util/rbs_assert.h
Outdated
|
|
||
| #include <stddef.h> | ||
|
|
||
| void rbs_assert(int condition, const char *fmt, ...); |
There was a problem hiding this comment.
Suggested change
| void rbs_assert(int condition, const char *fmt, ...); | |
| void rbs_assert(bool condition, const char *fmt, ...); |
amomchilov
reviewed
Mar 17, 2025
Morriar
approved these changes
Mar 17, 2025
st0012
force-pushed
the
introduce-rbs-assert
branch
2 times, most recently
from
acc59d3 to
877f2ee
Compare
st0012
force-pushed
the
introduce-rbs-assert
branch
from
877f2ee to
16e8ce1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Shopify/team-ruby-dx/issues/1422