[Form] Reorder form markup to prevent VisuallyHidden bug #5181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
emma-boardman
commented
Feb 15, 2022
| {submitMarkup} | ||
| {children} |
There was a problem hiding this comment.
This change doesn't impact implicitSubmit functionality:
Screen.Recording.2022-02-15.at.16.45.39.mov
It also won't affect the order AT users encounter the markup - the VisuallyHidden button here is aria-hidden.
alex-page
approved these changes
Feb 15, 2022
|
@alex-page how do I get the
|
6 tasks
|
@emma-boardman shipping this |
2 tasks
chloerice
pushed a commit
that referenced
this pull request
Mar 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The
top: 0CSS was removed fromVisuallyHiddenin Polaris v7.4.0.In long forms that utilise the deprecated
Sheet, the updated positioning ofVisuallyHiddenin aFormcomponent scrolls the underlying Form out of view when theSheetis opened.In
online-store-web, this scrolling was causing thePopoverinside theAddMenuItemsheet to close immediately after opening.Full context from support: https://shopify.slack.com/archives/C8RBQFF6U/p1644009960815369
📹 Media
Before
Screen.Recording.2022-02-15.at.17.21.57.mov
After
Screen.Recording.2022-02-15.at.17.06.04.mov
WHAT is this pull request doing?
submitMarkupandchildren🎩 checklist