Indexfilters search proto just move search #12614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[IndexFilters] Remove search from FilterButton [IndexFilters] Add a SearchField subcomponent [IndexFilters] Move search input beside tabs; prototype add as filter UX [IndexFilters] Update stories to change search placeholder tab reference when active tab changes [Storybook][Test Pages] Create a new ProductsPage story for prototype WIP mock saved filter logic (have to fake outside of admin) switch prototype to tabless filterless orders index ignore commas when filtering by query filter Improve order data with David's feedback Implement fully working tabs and filters to flesh out the table [Key dev dependencies] Bumped TS and Storybook packages Ensure special chars like '#' don't break search
…d filtering mode when appliedFilters change
chloerice
force-pushed
the
indexfilters-search-proto--just-move-search
branch
from
b18535c
to
484e1a2
Compare
chloerice
force-pushed
the
indexfilters-search-proto--just-move-search
branch
from
484e1a2
to
f56cfa2
Compare
chloerice
force-pushed
the
indexfilters-search-proto--just-move-search
branch
2 times, most recently
from
06eaf78
to
77e452d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes