Add strict locals linter #395
Open
+125
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonlevasseur
force-pushed
the
strict-locals-linter
branch
from
fda7f65 to
9c88a47
Compare
simonlevasseur
force-pushed
the
strict-locals-linter
branch
from
9c88a47 to
ee27743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #338
Implement the strict locals linter. It checks for any ERB entry that matches the following regex:
\s+locals:\s+\((.*)\). The regex was made to match the Rails strict locals regex here. The "#" is omitted because the parser separated the indicator node from the code node.