Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to sharepoint throttling page #10157

Merged
merged 11 commits into from
Mar 24, 2025
Merged

Conversation

killerewok2000
Copy link
Contributor

Category

  • Content fix
  • New article

Related issues

  • fixes #issuenumber
  • partially #issuenumber
  • mentioned in #issuenumber

What's in this Pull Request?

Added table of existing limits into the article to reduce confusion.

Submission guidelines

Copy link
Contributor

Learn Build status updates of commit 07ae325:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/general-development/how-to-avoid-getting-throttled-or-blocked-in-sharepoint-online.md ⚠️Warning View Details

docs/general-development/how-to-avoid-getting-throttled-or-blocked-in-sharepoint-online.md

  • Line 13, Column 3: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#what-is-throttling?' in 'general-development/how-to-avoid-getting-throttled-or-blocked-in-sharepoint-online.md', did you mean '#what-is-throttling'?

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@killerewok2000 killerewok2000 changed the title Patch 3 Update to sharepoint throttling page Mar 17, 2025
Copy link
Contributor

Learn Build status updates of commit 56459de:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/general-development/how-to-avoid-getting-throttled-or-blocked-in-sharepoint-online.md ⚠️Warning View Details

docs/general-development/how-to-avoid-getting-throttled-or-blocked-in-sharepoint-online.md

  • Line 14, Column 3: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#what-is-throttling?' in 'general-development/how-to-avoid-getting-throttled-or-blocked-in-sharepoint-online.md', did you mean '#what-is-throttling'?

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@andrewconnell andrewconnell self-assigned this Mar 18, 2025
Copy link
Contributor

Learn Build status updates of commit b6af13f:

✅ Validation status: passed

File Status Preview URL Details
docs/general-development/how-to-avoid-getting-throttled-or-blocked-in-sharepoint-online.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@VesaJuvonen
Copy link
Contributor

@andrewconnell - let's not merge this to main until 24th of March - I can do that do immediate publishing as well to control the timing if it's otherwise ready to go.

Copy link
Contributor

Learn Build status updates of commit 91c91dd:

✅ Validation status: passed

File Status Preview URL Details
docs/general-development/how-to-avoid-getting-throttled-or-blocked-in-sharepoint-online.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 3ff64d4:

✅ Validation status: passed

File Status Preview URL Details
docs/general-development/how-to-avoid-getting-throttled-or-blocked-in-sharepoint-online.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Collaborator

@andrewconnell andrewconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the preview rendering of this page from the build report and comment back that everything is rendering correctly, specifically the parts I've called out in my specific line item comments below. I'm currently traveling & unable to access the MSFT preview site (only accessible via CORPNET) as I don't have my MSFT domain joined machine with me.

@andrewconnell andrewconnell added Needs: Author Feedback Awaiting response from the original poster of the issue. Marked as stale if no activity for 7 days. pr:do-not-merge Pull request not ready to be merged labels Mar 20, 2025
@andrewconnell
Copy link
Collaborator

@VesaJuvonen said:

@andrewconnell - let's not merge this to main until 24th of March - I can do that do immediate publishing as well to control the timing if it's otherwise ready to go.

No problem... but there are some things that should be fixed. I can't see the preview rendering of the page on CORPNET while traveling... can you verify the latest build with my edits is ok?

@VesaJuvonen
Copy link
Contributor

@VesaJuvonen said:

@andrewconnell - let's not merge this to main until 24th of March - I can do that do immediate publishing as well to control the timing if it's otherwise ready to go.

No problem... but there are some things that should be fixed. I can't see the preview rendering of the page on CORPNET while traveling... can you verify the latest build with my edits is ok?

Noted - in general rendering looks ok, but let's indeed get the pending topics fixed/updated. We should not indeed anymore use RaaS term in the docs.

@killerewok2000
Copy link
Contributor Author

Feedback has been addressed thanks

Copy link
Contributor Author

@killerewok2000 killerewok2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all feedback should be addressed

Copy link
Contributor

Learn Build status updates of commit 1ba1ff7:

✅ Validation status: passed

File Status Preview URL Details
docs/general-development/how-to-avoid-getting-throttled-or-blocked-in-sharepoint-online.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@andrewconnell andrewconnell added pr:in-review Actively reviewing pull request and removed pr:do-not-merge Pull request not ready to be merged Needs: Author Feedback Awaiting response from the original poster of the issue. Marked as stale if no activity for 7 days. labels Mar 22, 2025
Copy link
Collaborator

@andrewconnell andrewconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few more fixes, but LGTM.

@VesaJuvonen AFAIC, this is ready to go live, but yield to you to merge to master and publish when you're ready per your previous comment. 👍

@andrewconnell andrewconnell added pr:ready-to-merge Ready to merge PR and removed pr:in-review Actively reviewing pull request labels Mar 22, 2025
Copy link
Contributor

Learn Build status updates of commit 13f6324:

✅ Validation status: passed

File Status Preview URL Details
docs/general-development/how-to-avoid-getting-throttled-or-blocked-in-sharepoint-online.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@VesaJuvonen VesaJuvonen merged commit c9d71bb into SharePoint:main Mar 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-to-merge Ready to merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants