Kernel/aarch64: Don't use the memory before .text as the initial stack (+ some linker script fixes) #25313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new stack has the same size as the initial stack on riscv64 and x86_64.
Also remove some trailing whitespace.
MemoryManager::protect_kernel_image uses these symbols.
github-actions
bot
added
the
👀 pr-needs-review
nico
reviewed
Nov 7, 2024
Kernel/Arch/aarch64/linker.ld
Outdated
| @@ -30,7 +30,6 @@ SECTIONS | |||
| end_of_safemem_atomic_text = .; | |||
|
|
|||
| *(.text*) | |||
| end_of_kernel_text = .; | |||
There was a problem hiding this comment.
Did you intentionally remove this here?
There was a problem hiding this comment.
I moved it to the end of .unmap_after_init. That matches the position of the symbol on x86-64 and riscv64.
(.unmap_after_init is also part of the text pheader)
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the initial aarch64 stack similar to how #23205 moved it for RISC-V.
I also included some small improvements to the aarch64 linker script while I'm here.