LibGfx+LibPDF: Add support for stroke dash patterns #25311
Merged
+253
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for dash patterns to Path::stroke_to_fill(). This is used in PDFs, <canvas>, and <svg>. The implementation is based on the <canvas> spec. It seems to do the right thing for PDF files too. (This commit only adds the feature to LibGfx. Future commits will hook this up for PDF, <canvas>, and <svg>.)
We used to store them as ints, which threw away information. In practice, files do use fractional values for these.
github-actions
bot
added
the
👀 pr-needs-review
|
The new Tests/LibPDF/paths.pdf, before:
After:
Before: 
After: 
Before: 
After: 
Before: 
After: 
|
|
Oh, and of course, before: 
After: 
|
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for dash patterns to Path::stroke_to_fill().
This is used in PDFs,
<canvas>, and<svg>.The implementation is based on the
<canvas>spec. It seems to dothe right thing for PDF files too.
This is hooked up in LibPDF. Future commits will do
<canvas>and<svg>.