Meta+Toolchain+Userland+AK: Bring Jakt in as part of the toolchain! #24910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
|
Commits are slightly messed-up, will fix. |
alimpfard
commented
Aug 6, 2024
alimpfard
force-pushed
the
jakt-2
branch
2 times, most recently
from
337f1b1
to
3baaa66
Compare
DanShaders
reviewed
Aug 6, 2024
alimpfard
force-pushed
the
jakt-2
branch
8 times, most recently
from
7eb4ad8
to
40681b9
Compare
alimpfard
commented
Aug 8, 2024
alimpfard
force-pushed
the
jakt-2
branch
4 times, most recently
from
9283c8b
to
33dc5f8
Compare
alimpfard
force-pushed
the
jakt-2
branch
6 times, most recently
from
2f620e5
to
366ffe6
Compare
nico
approved these changes
Aug 21, 2024
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
The existing version simply crashed if the expected layout wasn't in line with reality.
This also updates the hello-world "utility". Co-Authored-By: Andrew Kaster <[email protected]>
|
YOLO. |
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #20765