LibPDF: Let LineDashPattern store data as floats

We used to store them as ints, which threw away information. In practice, files do use fractional values for these.
SerenityOS · Nov 7, 2024 · ebf67de · ebf67de
1 parent d569238
commit ebf67de
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Userland/Libraries/LibPDF/Renderer.cpp b/Userland/Libraries/LibPDF/Renderer.cpp
@@ -210,10 +210,10 @@ RENDERER_HANDLER(set_miter_limit)
 RENDERER_HANDLER(set_dash_pattern)
 {
     auto dash_array = MUST(m_document->resolve_to<ArrayObject>(args[0]));
-    Vector<int> pattern;
+    Vector<float> pattern;
     for (auto& element : *dash_array)
-        pattern.append(element.to_int());
-    state().line_dash_pattern = LineDashPattern { pattern, args[1].to_int() };
+        pattern.append(element.to_float());
+    state().line_dash_pattern = LineDashPattern { pattern, args[1].to_float() };
     return {};
 }
 

diff --git a/Userland/Libraries/LibPDF/Renderer.h b/Userland/Libraries/LibPDF/Renderer.h
@@ -37,8 +37,8 @@ enum class LineJoinStyle : u8 {
 };
 
 struct LineDashPattern {
-    Vector<int> pattern;
-    int phase;
+    Vector<float> pattern;
+    float phase;
 };
 
 enum class TextRenderingMode : u8 {