[CLI] Ask for confirmation before creating shared recovery. #9370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AureliaDolo
force-pushed
the
aurelia/cli/confirm_shamir_creation
branch
from
523e361 to
14157ce
Compare
vxgmichel
approved these changes
Jan 17, 2025
| .. | ||
| } = args; | ||
| dbg!(no_confirmation); |
| .find(|x| x.id == *recipient) | ||
| .expect("missing recipient") | ||
| .human_handle; | ||
| format!("{BULLET_CHAR} User {user} will have {share} share(s)") // TODO: special case if there is only one share |
There was a problem hiding this comment.
Maybe treat this now since it's simple enough?
There was a problem hiding this comment.
It's in quite a few other places too.
AureliaDolo
force-pushed
the
aurelia/cli/confirm_shamir_creation
branch
from
14157ce to
a748596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9125