Use cube chunks for weights in aggregations with smart weights #6288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlunma
commented
Jan 16, 2025
Comment on lines
+408
to
+409
| these chunks. The values provided here will only be used along | ||
| dimensions that are not latitude or longitude. |
There was a problem hiding this comment.
I forgot to change this in #5658 (comment).
schlunma
commented
Jan 16, 2025
Comment on lines
-1195
to
-1196
| # Note: chunks is simply ignored for non-lazy data | ||
| @pytest.mark.parametrize("chunks", [None, (2, 3)]) |
There was a problem hiding this comment.
chunks is not used here, and marks could never be applied to fixtures, so this can be safely removed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6288 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 88 88
Lines 23384 23387 +3
Branches 4356 4357 +1
=======================================
+ Hits 21012 21015 +3
Misses 1646 1646
Partials 726 726 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Use cube chunks for smart weights when broadcasting is necessary.
Closes #6285.
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: