Fixed up the Nelson ODE function

[nnd389]

Checklist

• Appropriate tests were added
• Any code changes were done in a way that does not break public API
• All documentation related to code changes were updated
• The new code follows the
  contributor guidelines, in particular the SciML Style Guide and
  COLPRAC.
• Any new documentation only uses public API

Additional context

Hello! My name is Nina De La Torre, and I wrote this ODE function! It was such a pleasant surprise to see it on the Julia documentation website, but the version that was used was unfinished, and I wanted to fix it up a bit. Anyways, here is the same function but a bit nicer to look at, with helpful comments, parameters, and a cute name. I am planning to request updates the other nelson files as well. I hope this is helpful!

Kindly,
Nina

[ChrisRackauckas]

Hi! Stella showed me this example to turn it into a benchmark, but of course I don't know the model all that much so thank you for your contributions.

Note that this repo is the website output files, but it's generated by https://github.com/SciML/SciMLBenchmarks.jl. Thus the files here shouldn't be updated directly, instead https://github.com/SciML/SciMLBenchmarks.jl/blob/master/benchmarks/AstroChem/nelson.jmd should be updated and the CI will automatically generate the results from the script. Could you make a PR to the generator with these changes?

[ChrisRackauckas]

Is there a reason for using the high tolerances here? That's almost certainly the reason why they are different from the reference.

[nnd389]

Hello! I’ll create a new pull request on the generator soon. No reason for the high tolerances, I just thought it made a fun looking graph. HCO+ just happens to have very small values, most of the other species don’t experience visible solver issues. I think the Rosenbrock (Radaus4) methods worked best for me even with high tolerances though.

…

On Thu, Oct 24, 2024 at 11:12 PM Christopher Rackauckas < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In markdown/AstroChem/nelson.md <#7 (comment)> : > +sol2 = solve(prob, FBDF()) +sol3 = solve(prob, QNDF()) +sol4 = solve(prob, CVODE_BDF()) Is there a reason for using the high tolerances here? That's almost certainly the reason why they are different from the reference. — Reply to this email directly, view it on GitHub <#7 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BHYFG4J4IMKOMFB64QEZUJ3Z5HAJ7AVCNFSM6AAAAABQSLURVWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJUGEZDMNJVGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>