Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add initialization_data to all SciMLFunctions #850

Merged
merged 1 commit into from
Nov 8, 2024
Merged

feat: add initialization_data to all SciMLFunctions #850

merged 1 commit into from
Nov 8, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member 

MethodError: no method matching plottable_indices(::Float64)

We need a fallback for ::Number

@ChrisRackauckas ChrisRackauckas merged commit 51261d1 into SciML:master Nov 8, 2024
30 of 51 checks passed
@AayushSabharwal AayushSabharwal deleted the as/initdata-everywhere branch November 8, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AayushSabharwal @ChrisRackauckas