Add nlprob to ODEFunction #800
Conversation
oscardssmith
force-pushed
the
os/ode-nlfunc-support
branch
from
7b6ce3a
to
3fefd1b
Compare
oscardssmith
force-pushed
the
os/ode-nlfunc-support
branch
2 times, most recently
from
f4d8e36
to
3ded92b
Compare
oscardssmith
changed the title
|
The downstream CI failures don't make sense to me. It looks like the downstream is only seeing some of the changes from #816, but I don't really understand it. Closing and reopening to see if that makes CI happier. |
|
Is this ready @oscardssmith |
|
no it needs a quick fix that I'll get to this morning. I'll ping when ready. |
oscardssmith
force-pushed
the
os/ode-nlfunc-support
branch
from
fdd9b3b
to
86eebab
Compare
|
OK I now think this should work. |
src/scimlfunctions.jl
Outdated
| @@ -289,6 +289,7 @@ the usage of `f`. These include: | |||
| based on the sparsity pattern. Defaults to `nothing`, which means a color vector will be | |||
| internally computed on demand when required. The cost of this operation is highly dependent | |||
| on the sparsity pattern. | |||
| - `nlfunc`: a `NonlinearFunction` | |||
There was a problem hiding this comment.
docs actually added
|
Looks good to go but needs a real docstring 😅 |
|
changed to be a nlprob instead of nlfunc (to be closer to initializeprob). |
|
It's still not sufficiently documented... but I'm not going to hold it up anymore. Come back to document it when we have a clearer sense of what it is. |
|
what else do you want for docs? |
|
Define mathematically what that problem is, what its parameters are, etc. |
No description provided.