Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix promoted tspan for BVProblem and ODEProblem #474

Merged
merged 7 commits into from
Jul 30, 2023

Conversation

ErikQQY
Copy link
Member

@ErikQQY ErikQQY commented Jul 28, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #474 (6bf34a8) into master (5d0b887) will increase coverage by 9.44%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
+ Coverage   47.17%   56.61%   +9.44%     
==========================================
  Files          47       47              
  Lines        3572     3582      +10     
==========================================
+ Hits         1685     2028     +343     
+ Misses       1887     1554     -333     
Files Changed Coverage Δ
src/ensemble/ensemble_problems.jl 42.85% <ø> (+19.04%) ⬆️
src/problems/bvp_problems.jl 56.66% <ø> (+12.66%) ⬆️
src/problems/ode_problems.jl 56.41% <100.00%> (+2.56%) ⬆️

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas
Copy link
Member

This needs a test.

Signed-off-by: ErikQQY <[email protected]>
Signed-off-by: ErikQQY <[email protected]>
Signed-off-by: ErikQQY <[email protected]>
Signed-off-by: ErikQQY <[email protected]>
@ChrisRackauckas ChrisRackauckas merged commit 3106af0 into SciML:master Jul 30, 2023
56 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants