Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support passing symbolic variables to save_idxs #2486

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

AayushSabharwal
Copy link
Member

Requires SciML/SciMLBase.jl#809

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal AayushSabharwal marked this pull request as ready for review October 28, 2024 11:38
@ChrisRackauckas
Copy link
Member

Test failures

@ChrisRackauckas
Copy link
Member

Rebase for LTS tests?

@AayushSabharwal
Copy link
Member Author

This is rebased and testing LTS

@ChrisRackauckas ChrisRackauckas merged commit 1d05b16 into SciML:master Nov 4, 2024
122 of 138 checks passed
@AayushSabharwal AayushSabharwal deleted the as/symbolic-save-idxs branch November 4, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants