Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NonlinearLeastSquaresProblem Solvers: Levenberg & Gauss Newton #218

Merged
merged 13 commits into from
Oct 10, 2023

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Sep 21, 2023

@avik-pal avik-pal marked this pull request as draft September 21, 2023 19:57
@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #218 (9a579c8) into master (cc04a70) will increase coverage by 93.75%.
The diff coverage is 85.58%.

@@             Coverage Diff             @@
##           master     #218       +/-   ##
===========================================
+ Coverage    0.00%   93.75%   +93.75%     
===========================================
  Files           8        9        +1     
  Lines         775      832       +57     
===========================================
+ Hits            0      780      +780     
+ Misses        775       52      -723     
Files Coverage Δ
src/NonlinearSolve.jl 89.47% <100.00%> (+89.47%) ⬆️
src/levenberg.jl 98.42% <100.00%> (+98.42%) ⬆️
src/raphson.jl 100.00% <ø> (+100.00%) ⬆️
src/trustRegion.jl 99.35% <100.00%> (+99.35%) ⬆️
src/utils.jl 78.40% <100.00%> (+78.40%) ⬆️
src/jacobian.jl 88.52% <88.88%> (+88.52%) ⬆️
src/gaussnewton.jl 75.00% <75.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@avik-pal avik-pal marked this pull request as ready for review October 9, 2023 00:41
@avik-pal avik-pal closed this Oct 9, 2023
@avik-pal avik-pal reopened this Oct 9, 2023
@avik-pal avik-pal closed this Oct 9, 2023
@avik-pal avik-pal reopened this Oct 9, 2023
@avik-pal
Copy link
Member Author

avik-pal commented Oct 9, 2023

This is ready for merge!

@ChrisRackauckas ChrisRackauckas merged commit 8a15dd6 into SciML:master Oct 10, 2023
16 of 18 checks passed
@avik-pal avik-pal deleted the ap/nls2 branch October 10, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants