Translate Particle problem to EnsembleProblem #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # [state_index][mc_index] | ||
| utraj = map(t) do t | ||
| data = reduce(hcat, OrdinaryDiffEq.EnsembleAnalysis.componentwise_vectors_timepoint(esol,t)) # nmc × nx |
There was a problem hiding this comment.
Suggested change
| data = reduce(hcat, OrdinaryDiffEq.EnsembleAnalysis.componentwise_vectors_timepoint(esol,t)) # nmc × nx | |
| data = reduce(hcat, SciMLBase.EnsembleAnalysis.componentwise_vectors_timepoint(esol,t)) # nmc × nx |
|
In principle this looks fine, though it should probably go to SciMLBase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds WIP functionality that automatically translates an
ODEPRoblem{<:Particles}into anEnsembleProblem, solves the ensemble problem, and finally repackages the solution into an ODESolution with Particles.This is an attempt at making MCM work with DAEs and other things that might be thrown off by the uncertain numbers.
The PR is WIP, I am quite unsure about how to create the final
ODESolution{Particles}. The current state of the PR kind-of works in some cases but not in others. There might also be problems in the interaction between the plotting recipe forParticlesand that forODESolution, if I plot a single state-variable only, it works fine, but when plotting multipleidxsat the same time I get a garbage plot.Any initial comments on what I might be doing wrong when I create the solution below is appreciated.